Skip to content

Conversation

pmikolajczyk41
Copy link
Member

Previously the _codecov workflow required CODECOV_TOKEN. As a result, external fork PRs were failing, like #3847. However, we need this token only on merging to master.

This PR sets this secret as non-mandatory.

cc: @KolbyML

Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

@eljobe eljobe added this pull request to the merge queue Oct 16, 2025
Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2025
@pmikolajczyk41 pmikolajczyk41 added this pull request to the merge queue Oct 16, 2025
Merged via the queue into master with commit 9ffca49 Oct 16, 2025
25 checks passed
@pmikolajczyk41 pmikolajczyk41 deleted the pmikolajczyk/allow-codecov-report-for-forks branch October 16, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants