-
Notifications
You must be signed in to change notification settings - Fork 644
Add precompiles for Multi-Constraint Pricer #3860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
6ab7990
to
60168e0
Compare
60168e0
to
708fcd3
Compare
// contracts should be counted. | ||
expectedNewEntriesPerArbosVersion := map[uint64]int{ | ||
0: 99, | ||
0: 101, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add those two precompiles to ArbosVersion_50. See https://github.com/OffchainLabs/nitro/blob/708fcd36ca/precompiles/precompile.go#L537
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About GetGasAccountingParams
being deprecated, I think this makes sense, but we should also create another method that returns just the block gas limit. This is not used directly by the L2 gas pricing model, but it is used in other places, so it is a good opportunity to clean this up. See #3545
Fixes NIT-4021
Depends on OffchainLabs/nitro-precompile-interfaces#19
contracts-local/src
on "Add precompile interfaces for Multi-Constraint Pricer"