Skip to content

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Oct 16, 2025

cherry picks #3851

FillInBatchGas might fail, esp. if reading the last batch failed.
Dont depend on it for getNextBlockToRead
@joshuacolvin0 joshuacolvin0 changed the title cherrypick- getNextBlockToRead does not deped on FillInBatchGasField (#3851) Port - getNextBlockToRead does not deped on FillInBatchGasField (#3851) Oct 16, 2025
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 4227717 into v3.8.x-release Oct 16, 2025
15 of 16 checks passed
@joshuacolvin0 joshuacolvin0 deleted the cherrypick-3851PR branch October 16, 2025 18:59
Copy link

❌ 77 Tests Failed:

Tests completed Failed Passed Skipped
2116 77 2039 0
View the top 3 failed tests by shortest run time
TestBlockValidatorSimpleJITOnchain
Stack Traces | -0.000s run time
=== RUN   TestBlockValidatorSimpleJITOnchain
=== PAUSE TestBlockValidatorSimpleJITOnchain
TestFinalizedBlocksMovedToAncients
Stack Traces | -0.000s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
github.com/ethereum/go-ethereum/core.(*stateTransition).execute(0xc35dc1ca80)
	/home/runner/work/nitro/nitro/go-ethereum/core/state_transition.go:575 +0x39
github.com/ethereum/go-ethereum/core.ApplyMessage(0xc3421f05a0, 0xc389ba3860, 0xc2521b6be0)
	/home/runner/work/nitro/nitro/go-ethereum/core/state_transition.go:356 +0x15f
github.com/ethereum/go-ethereum/core.ApplyTransactionWithEVM(0x35be020?, 0xc3a38d9408?, 0xc018101680, 0xc3551bcfe0, {0x64, 0x87, 0xe7, 0x1a, 0x48, 0x6, ...}, ...)
	/home/runner/work/nitro/nitro/go-ethereum/core/state_processor.go:154 +0x188
github.com/ethereum/go-ethereum/core.ApplyTransactionWithResultFilter(0xc3421f05a0, 0xc2521b6be0, 0xc018101680, 0xc3a38d9408, 0xc4796b3680, 0xc3a38d95d8, 0xc33d41ac00, 0xc3b488f768)
	/home/runner/work/nitro/nitro/go-ethereum/core/state_processor.go:234 +0x152
github.com/offchainlabs/nitro/arbos.ProduceBlockAdvanced.func1(0xc3b488fa28, 0x0, 0xc3b488f8af, 0xc3b488fb80, {0x4063820?, 0xc1251e5280?}, 0xc4796b3680, 0x0, 0xc000294dc0, 0xc3a38d9408, ...)
	/home/runner/work/nitro/nitro/arbos/block_processor.go:375 +0x748
github.com/offchainlabs/nitro/arbos.ProduceBlockAdvanced(0xc334c2dd00, 0x6, 0xc35896ac88, 0xc018101680, {0x4058e90, 0xc3573d1008}, 0xc24ffafdc8, 0x1, 0xc33d41ac00, 0x1)
	/home/runner/work/nitro/nitro/arbos/block_processor.go:405 +0x985
github.com/offchainlabs/nitro/arbos.ProduceBlock(0xc33d4640f0, 0x6, 0xc35896ac88, 0xc018101680, {0x4058e90, 0xc3573d1008}, 0x1, 0xc33d41ac00, 0x1)
	/home/runner/work/nitro/nitro/arbos/block_processor.go:198 +0x33e
github.com/offchainlabs/nitro/execution/gethexec.(*ExecutionEngine).createBlockFromNextMessage(0xc0b79e4a00, 0xc15bcb72c0, 0x1)
	/home/runner/work/nitro/nitro/execution/gethexec/executionengine.go:798 +0x6a5
github.com/offchainlabs/nitro/execution/gethexec.(*ExecutionEngine).digestMessageWithBlockMutex.func1()
	/home/runner/work/nitro/nitro/execution/gethexec/executionengine.go:993 +0x25
created by github.com/offchainlabs/nitro/execution/gethexec.(*ExecutionEngine).digestMessageWithBlockMutex in goroutine 3780577
	/home/runner/work/nitro/nitro/execution/gethexec/executionengine.go:992 +0x185
TestDimLogCallCodeWarmNoTransferNoCodeVirginMemExpansion
Stack Traces | -0.000s run time
=== RUN   TestDimLogCallCodeWarmNoTransferNoCodeVirginMemExpansion
=== PAUSE TestDimLogCallCodeWarmNoTransferNoCodeVirginMemExpansion

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants