Skip to content

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Oct 16, 2025

This PR cherrypicks #3853

@ganeshvanahalli ganeshvanahalli changed the title Cherrypick 3853 pr Port -[NIT-4019] Exclude BatchDataStats from feed for old ArbOS versions Oct 16, 2025
@joshuacolvin0 joshuacolvin0 changed the title Port -[NIT-4019] Exclude BatchDataStats from feed for old ArbOS versions Port -Exclude BatchDataStats from feed for old ArbOS versions (#3853) Oct 16, 2025
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 changed the title Port -Exclude BatchDataStats from feed for old ArbOS versions (#3853) Port - Exclude BatchDataStats from feed for old ArbOS versions (#3853) Oct 16, 2025
Copy link

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2139 2 2137 0
View the top 2 failed tests by shortest run time
TestArbOSVersion50
Stack Traces | 6.590s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
ERROR[10-16|20:21:52.366] Dangling trie nodes after full cleanup
    precompile_inclusion_test.go:90: goroutine 521767 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x4082570, 0xc0a94528c0}, {0x40407a0, 0xc0f966de90}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc0a94528c0, {0x40407a0, 0xc0f966de90}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc0a94528c0, 0x32, {0xc24d325e88, 0x3, 0x5be8b20?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestArbOSVersion50(0xc0a94528c0?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:75 +0x3ef
        testing.tRunner(0xc0a94528c0, 0x3cc99d0)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
�[90mkeccak: len 6.21K vs 18.02K�[0;0m
--- FAIL: TestArbOSVersion50 (6.59s)
TestEthSyncing
Stack Traces | 66.360s run time
=== RUN   TestEthSyncing
=== PAUSE TestEthSyncing
=== CONT  TestEthSyncing
�[90ml1 basefee 50000000000�[0;0m
�[90ml2 basefee 100000000�[0;0m
�[34;1mEst. 1330101 - 1297450 = 32651�[0;0m
�[38;5;48;1mTrue 957020 - 936000 = 21020�[0;0m
    eth_sync_test.go:71: �[31;1m [eth_syncing returned nil but shouldn't have] �[0;0m
�[90mposted new batch 4�[0;0m
--- FAIL: TestEthSyncing (66.36s)
�[90mposted new batch 15�[0;0m
�[90mposted new batch 37�[0;0m

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joshuacolvin0 joshuacolvin0 merged commit 2fe5b83 into v3.8.x-release Oct 16, 2025
17 checks passed
@joshuacolvin0 joshuacolvin0 deleted the cherrypick-3853PR branch October 16, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants