[NIT-3755] Serialization order of the chain config in the init message changes the genesis block hash

[pmikolajczyk41]

Test fails because we write the serialization bytes directly to the initial storage: https://github.com/OffchainLabs/nitro/blob/master/arbos/arbosState/arbosstate.go#L242

Related PR: #3636 (introducing this 'problem' to out cmd)

[github-actions]

❌ 8 Tests Failed:

Tests completed	Failed	Passed	Skipped
2147	8	2139	0

View the top 3 failed tests by shortest run time

TestChainConfigSerializationOrderDoesNotChangeGenesisBlockHash

Stack Traces | 0.000s run time

=== RUN   TestChainConfigSerializationOrderDoesNotChangeGenesisBlockHash
    genesis_block_test.go:36: 
        	Error Trace:	/home/runner/work/nitro/nitro/system_tests/genesis_block_test.go:36
        	Error:      	Not equal: 
        	            	expected: 0xa7dfab3fcaedf6bac65ec23e0eeaf898f06f6b78e134b67b95fbbc35563163b1
        	            	actual  : 0xb5b3e3c3268a21fd2cadbfa655eb9b480b738c9b0af3b95c3478e05d01740c03
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,4 +1,4 @@
        	            	 (common.Hash) (len=32) {
        	            	- 00000000  a7 df ab 3f ca ed f6 ba  c6 5e c2 3e 0e ea f8 98  |...?.....^.>....|
        	            	- 00000010  f0 6f 6b 78 e1 34 b6 7b  95 fb bc 35 56 31 63 b1  |.okx.4.{...5V1c.|
        	            	+ 00000000  b5 b3 e3 c3 26 8a 21 fd  2c ad bf a6 55 eb 9b 48  |....&.!.,...U..H|
        	            	+ 00000010  0b 73 8c 9b 0a f3 b9 5c  34 78 e0 5d 01 74 0c 03  |.s.....\4x.].t..|
        	            	 }
        	Test:       	TestChainConfigSerializationOrderDoesNotChangeGenesisBlockHash
        	Messages:   	Genesis block hashes should be equal despite different serialization orders
--- FAIL: TestChainConfigSerializationOrderDoesNotChangeGenesisBlockHash (0.00s)

TestChainConfigSerializationOrderDoesNotChangeGenesisBlockHash

Stack Traces | 0.000s run time

=== RUN   TestChainConfigSerializationOrderDoesNotChangeGenesisBlockHash
    genesis_block_test.go:36: 
        	Error Trace:	/home/runner/work/nitro/nitro/system_tests/genesis_block_test.go:36
        	Error:      	Not equal: 
        	            	expected: 0xa7dfab3fcaedf6bac65ec23e0eeaf898f06f6b78e134b67b95fbbc35563163b1
        	            	actual  : 0xb5b3e3c3268a21fd2cadbfa655eb9b480b738c9b0af3b95c3478e05d01740c03
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,4 +1,4 @@
        	            	 (common.Hash) (len=32) {
        	            	- 00000000  a7 df ab 3f ca ed f6 ba  c6 5e c2 3e 0e ea f8 98  |...?.....^.>....|
        	            	- 00000010  f0 6f 6b 78 e1 34 b6 7b  95 fb bc 35 56 31 63 b1  |.okx.4.{...5V1c.|
        	            	+ 00000000  b5 b3 e3 c3 26 8a 21 fd  2c ad bf a6 55 eb 9b 48  |....&.!.,...U..H|
        	            	+ 00000010  0b 73 8c 9b 0a f3 b9 5c  34 78 e0 5d 01 74 0c 03  |.s.....\4x.].t..|
        	            	 }
        	Test:       	TestChainConfigSerializationOrderDoesNotChangeGenesisBlockHash
        	Messages:   	Genesis block hashes should be equal despite different serialization orders
--- FAIL: TestChainConfigSerializationOrderDoesNotChangeGenesisBlockHash (0.00s)

TestDataStreaming_PositiveScenario/Many_senders,_long_messages

Stack Traces | 0.310s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:248 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 249
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:241 +0x85
        
    protocol_test.go:248: �[31;1m [] failed after 3 attempts: too much time has elapsed since request was signed �[0;0m
WARN [10-17|14:53:04.258] Served datastreaming_start               conn=127.0.0.1:38508 reqid=385 duration="142.396µs" err="too much time has elapsed since request was signed"
INFO [10-17|14:53:04.259] rpc response                             method=datastreaming_start logId=385 err="too much time has elapsed since request was signed" result={} attempt=0 args="[\"0x68f2584f\", \"0x2e\", \"0xd9\", \"0x2634\", \"0xa\", \"0xd089028629c55fae27d03c94e859c47f0e9076f32b24a8926db2b9e07b12a8b500cc644ec2b4272f6bb49eeb8a5a02c4d78cf95962716fe97ba91cd0e0bb6e5001\"]" errorData=null
    protocol_test.go:248: goroutine 261 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x1567e90, 0xc00022e700}, {0x154d960, 0xc0003a8920}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:248 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 249
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:241 +0x85
        
    protocol_test.go:248: �[31;1m [] failed after 3 attempts: too much time has elapsed since request was signed �[0;0m
--- FAIL: TestDataStreaming_PositiveScenario/Many_senders,_long_messages (0.31s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov