Bug-fix: identify already exists errors correctly while creating assertions

[ganeshvanahalli]

This PR fixes a bug where previously the errors while creating assertions were handled via handleCreateAssertionError but then checked for already exists string against err instead of createErr, thus missing them and ultimately leading to incorrect numbers in metrics- arb_validator_poster_assertion_posted, as we only increment this metric after successfully creating an assertion.

eg: Assertions on etherscan don't seem to match nitro metrics

Resolves NIT-4001

[github-actions]

❌ 3 Tests Failed:

Tests completed	Failed	Passed	Skipped
2144	3	2141	0

View the top 3 failed tests by shortest run time

TestPrimaryToSecondaryFailover

Stack Traces | 5.430s run time

=== RUN   TestPrimaryToSecondaryFailover
=== PAUSE TestPrimaryToSecondaryFailover
=== CONT  TestPrimaryToSecondaryFailover
INFO [10-17|21:11:48.426] arbitrum websocket broadcast server is listening address=[::]:40951
    broadcastclients_test.go:203: Primary broadcaster listening on: [::]:40951
INFO [10-17|21:11:48.426] arbitrum websocket broadcast server is listening address=[::]:43945
    broadcastclients_test.go:204: Secondary broadcaster listening on: [::]:43945
    broadcastclients_test.go:227: Primary URL: ws://127.0.0.1:40951
    broadcastclients_test.go:228: Secondary URL: ws://127.0.0.1:43945
    broadcastclients_test.go:275: Phase 1: Sending messages from primary broadcaster
INFO [10-17|21:11:48.426] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:40951
INFO [10-17|21:11:48.427] Feed connected                           feedServerVersion=2 chainId=1234 requestedSeqNum=0
INFO [10-17|21:11:53.633] secondary feed started                   url=ws://127.0.0.1:43945 startingFromSeq=4
INFO [10-17|21:11:53.634] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:43945
INFO [10-17|21:11:53.634] Feed connected                           feedServerVersion=2 chainId=1234 requestedSeqNum=4
    broadcastclients_test.go:307: Timed out waiting for message 5/5 from primary
--- FAIL: TestPrimaryToSecondaryFailover (5.43s)

TestVersion30

Stack Traces | 13.910s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
=== PAUSE TestVersion30
=== CONT  TestVersion30
    precompile_inclusion_test.go:90: goroutine 455131 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x4084f50, 0xc069343a40}, {0x4043180, 0xc109b46cc0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc069343a40, {0x4043180, 0xc109b46cc0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc069343a40, 0x1e, {0xc07b6c3db0, 0x6, 0x0?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc069343a40?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc069343a40, 0x3ccd158)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (13.91s)

TestTimeboostExpressLaneTransactionHandling

Stack Traces | 17.930s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
DEBUG[10-17|21:19:24.278] Dereferenced trie from memory database   nodes=0   size=0.00B     time=201ns       gcnodes=441  gcsize=80.73KiB   gctime=43.450972ms livenodes=227   livesize=45.13KiB
DEBUG[10-17|21:19:24.278] Dereferenced trie from memory database   nodes=17  size=3.29KiB   time="57.588µs"  gcnodes=458  gcsize=84.02KiB   gctime=43.50834ms  livenodes=210   livesize=41.84KiB
DEBUG[10-17|21:19:24.279] Dereferenced trie from memory database   nodes=16  size=3.19KiB   time="43.12µs"   gcnodes=474  gcsize=87.21KiB   gctime=43.55133ms  livenodes=194   livesize=38.65KiB
DEBUG[10-17|21:19:24.279] Dereferenced trie from memory database   nodes=16  size=3.18KiB   time="51.456µs"  gcnodes=490  gcsize=90.39KiB   gctime=43.602666ms livenodes=178   livesize=35.47KiB
DEBUG[10-17|21:19:24.279] Dereferenced trie from memory database   nodes=16  size=3.22KiB   time="41.828µs"  gcnodes=506  gcsize=93.61KiB   gctime=43.644354ms livenodes=162   livesize=32.25KiB
DEBUG[10-17|21:19:24.279] Dereferenced trie from memory database   nodes=16  size=3.19KiB   time="40.797µs"  gcnodes=522  gcsize=96.80KiB   gctime=43.685001ms livenodes=146   livesize=29.05KiB
DEBUG[10-17|21:19:24.279] Dereferenced trie from memory database   nodes=16  size=3.18KiB   time="46.537µs"  gcnodes=538  gcsize=99.98KiB   gctime=43.731438ms livenodes=130   livesize=25.88KiB
DEBUG[10-17|21:19:24.279] Dereferenced trie from memory database   nodes=16  size=3.18KiB   time="39.313µs"  gcnodes=554  gcsize=103.16KiB  gctime=43.770601ms livenodes=114   livesize=22.70KiB
DEBUG[10-17|21:19:24.290] Dereferenced trie from memory database   nodes=16  size=3.22KiB   time=10.641853ms gcnodes=570  gcsize=106.38KiB  gctime=54.411913ms livenodes=98    livesize=19.48KiB
DEBUG[10-17|21:19:24.290] Dereferenced trie from memory database   nodes=17  size=3.29KiB   time="59.161µs"  gcnodes=587  gcsize=109.67KiB  gctime=54.470763ms livenodes=81    livesize=16.19KiB
DEBUG[10-17|21:19:24.290] Dereferenced trie from memory database   nodes=16  size=3.22KiB   time="54.583µs"  gcnodes=603  gcsize=112.89KiB  gctime=54.524695ms livenodes=65    livesize=12.96KiB
DEBUG[10-17|21:19:24.290] Dereferenced trie from memory database   nodes=16  size=3.22KiB   time="50.234µs"  gcnodes=619  gcsize=116.12KiB  gctime=54.574749ms livenodes=49    livesize=9.74KiB
DEBUG[10-17|21:19:24.290] Dereferenced trie from memory database   nodes=15  size=3.08KiB   time="58.108µs"  gcnodes=634  gcsize=119.20KiB  gctime=54.632517ms livenodes=34    livesize=6.66KiB
DEBUG[10-17|21:19:24.290] Dereferenced trie from memory database   nodes=18  size=3.45KiB   time="90.429µs"  gcnodes=652  gcsize=122.65KiB  gctime=54.722776ms livenodes=16    livesize=3.21KiB
DEBUG[10-17|21:19:24.290] Dereferenced trie from memory database   nodes=16  size=3.21KiB   time="54.482µs"  gcnodes=668  gcsize=125.86KiB  gctime=54.777067ms livenodes=0     livesize=0.00B
DEBUG[10-17|21:19:24.291] Dereferenced trie from memory database   nodes=0   size=0.00B     time=631ns       gcnodes=668  gcsize=125.86KiB  gctime=54.777367ms livenodes=0     livesize=0.00B
DEBUG[10-17|21:19:24.291] Dereferenced trie from memory database   nodes=0   size=0.00B     time=501ns       gcnodes=668  gcsize=125.86KiB  gctime=54.777718ms livenodes=0     livesize=0.00B
INFO [10-17|21:19:24.291] Blockchain stopped
TRACE[10-17|21:19:24.295] P2P networking is spinning down
--- FAIL: TestTimeboostExpressLaneTransactionHandling (17.93s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

[joshuacolvin0]

LGTM