Skip to content

Conversation

bragaigor
Copy link

@bragaigor bragaigor commented Oct 17, 2025

fixes NIT-4027
pulls-in OffchainLabs/go-ethereum#562

Updates go-ethereum submodule with the version that contains the fix that adds a map to store transaction hash along with its gas used to bypass transaction execution for problematic txs execution on ARM architecture.

@bragaigor bragaigor marked this pull request as ready for review October 17, 2025 21:25
Copy link

github-actions bot commented Oct 17, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
2144 3 2141 0
View the top 3 failed tests by shortest run time
TestVersion30
Stack Traces | 15.830s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== PAUSE TestVersion30
=== CONT  TestVersion30
    precompile_inclusion_test.go:90: goroutine 454916 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x4086010, 0xc08b5db6c0}, {0x4044240, 0xc006be34d0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc08b5db6c0, {0x4044240, 0xc006be34d0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc08b5db6c0, 0x1e, {0xc089b49db0, 0x6, 0xc060902720?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc08b5db6c0?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc08b5db6c0, 0x3cce1d8)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (15.83s)
TestEthSyncing
Stack Traces | 25.820s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [10-18|02:10:55.393] Initialising Ethereum protocol           network=412,346 dbversion=<nil>
DEBUG[10-18|02:10:55.393] Served eth_getBlockByNumber              reqid=38    duration="92.973µs"
TRACE[10-18|02:10:55.393] Handled RPC response                     reqid=714   duration="2.365µs"
TRACE[10-18|02:10:55.393] Handled RPC response                     reqid=38    duration="2.224µs"
INFO [10-18|02:10:55.393] Load database journal from disk
TRACE[10-18|02:10:55.393] Handled RPC response                     reqid=1295  duration="1.854µs"
DEBUG[10-18|02:10:55.393] Served eth_getBlockByHash                reqid=191   duration="239.247µs"
INFO [10-18|02:10:55.394] State snapshot generator is not found
INFO [10-18|02:10:55.394] Starting snapshot generation             root=56e81f..63b421 accounts=0  slots=0     storage=0.00B   dangling=0 elapsed="2.985µs"
INFO [10-18|02:10:55.394] Initialized path database                triecache=154.00MiB statecache=102.00MiB buffer=256.00MiB state-history="last 90000 blocks"
INFO [10-18|02:10:55.394] Writing custom genesis block
TRACE[10-18|02:10:55.394] Handled RPC response                     reqid=191   duration="2.354µs"
INFO [10-18|02:10:55.394] Resuming snapshot generation             root=56e81f..63b421 accounts=0  slots=0     storage=0.00B   dangling=0 elapsed="420.654µs"
DEBUG[10-18|02:10:55.394] Journalled generator progress            progress=empty
TRACE[10-18|02:10:55.394] Proved state range                       kind=account prefix=0x61 last=0x
DEBUG[10-18|02:10:55.394] Journalled generator progress            progress=done
INFO [10-18|02:10:55.394] Generated snapshot                       accounts=0  slots=0     storage=0.00B   dangling=0 elapsed="532.308µs"
DEBUG[10-18|02:10:55.395] Created new diff layer                   id=1                  block=0   nodesize=4.06KiB  statesize=1.94KiB
DEBUG[10-18|02:10:55.395] Served eth_getBlockByNumber              reqid=4323  duration="84.097µs"
--- FAIL: TestEthSyncing (25.82s)
TestTwoNodesLong
Stack Traces | 84.320s run time
=== RUN   TestTwoNodesLong
=== PAUSE TestTwoNodesLong
=== CONT  TestTwoNodesLong
    twonodeslong_test.go:80: DelayedFaucet has 80008000000000000800, per delayed: 100000000000000001, baseprice: 1e+08
    twonodeslong_test.go:136: Done sending 29 delayed transfers 201 direct transfers
    twonodeslong_test.go:169: delayed balance 2900000000000000029 expected 2900000000000000029 transfers 29
    twonodeslong_test.go:170: direct balance 38400576 expected 40200603 transfers 201
    twonodeslong_test.go:173: owner balance 115792089237316195423570985008687907853269984665640564039457584007913129639927 delayed faucet 77107939100000000771
    twonodeslong_test.go:174: �[31;1m [Unexpected balance] �[0;0m
--- FAIL: TestTwoNodesLong (84.32s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant