Skip to content

Fix broadcast client shutdown deadlock #3882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −2
Open

Fix broadcast client shutdown deadlock #3882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions broadcastclient/broadcastclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,10 @@ func (bc *BroadcastClient) Start(ctxIn context.Context) {
errors.Is(err, ErrIncorrectChainId) ||
errors.Is(err, ErrMissingFeedServerVersion) ||
errors.Is(err, ErrIncorrectFeedServerVersion) {
bc.fatalErrChan <- fmt.Errorf("failed connecting to server feed due to %w", err)
select {
case bc.fatalErrChan <- fmt.Errorf("failed connecting to server feed due to %w", err):
case <-ctx.Done():
}
return
}
if err == nil {
Expand Down Expand Up @@ -491,7 +494,11 @@ func (bc *BroadcastClient) startBackgroundReader(earlyFrameData io.Reader) {
}
}
if res.ConfirmedSequenceNumberMessage != nil && bc.confirmedSequenceNumberListener != nil {
bc.confirmedSequenceNumberListener <- res.ConfirmedSequenceNumberMessage.SequenceNumber
select {
case bc.confirmedSequenceNumberListener <- res.ConfirmedSequenceNumberMessage.SequenceNumber:
case <-ctx.Done():
return
}
}
}
}
Expand Down
Loading