Skip to content

Conversation

@davidjsonn
Copy link
Contributor

When multiple inner storage services failed, RedundantStorageService was only returning the last error, silently discarding all previous ones. This made debugging really hard because you'd only see one failure even if three services were down for different reasons.

Changed GetByHash, Put, Sync, and Close methods to collect all errors into a slice and return them via errors.Join(). Now when something goes wrong, you actually get the full picture of what failed.

@Tristan-Wilson Tristan-Wilson added the trivial Adding this tag auto-closes trivial PRs politely. label Dec 10, 2025
@github-actions
Copy link

Thank you for your contribution. However, this PR has been automatically closed because it was labeled as trivial. As stated in our CONTRIBUTING.md:


Important

Please, do not send pull requests for trivial changes; these will be rejected.
These types of pull requests incur a cost to reviewers and do not provide much value to the project.
If you are unsure, please open an issue first to discuss the change.
Here are some examples of trivial PRs that will most-likely be rejected:

  • Fixing typos
  • AI-generated code
  • Refactors that don't improve usability

We appreciate meaningful contributions!

@github-actions github-actions bot closed this Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trivial Adding this tag auto-closes trivial PRs politely.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants