-
Notifications
You must be signed in to change notification settings - Fork 688
Add isActiveSequencer to ExpressLaneTracker log messages #4131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tristan-Wilson
wants to merge
1
commit into
master
Choose a base branch
from
timeboost-auction-resolution-active-sequencer-log
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add isActiveSequencer to ExpressLaneTracker log messages #4131
Tristan-Wilson
wants to merge
1
commit into
master
from
timeboost-auction-resolution-active-sequencer-log
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running multiple sequencers in HA mode, all nodes run an ExpressLaneTracker that polls for auction resolution events. This means the "AuctionResolved" and "New express lane auction round" log messages appear on every sequencer node, making it difficult for operators to distinguish which node is active vs standby. Add isActiveSequencer field to these log messages so operators can identify whether the logging node is the active sequencer (sequencing transactions) or an inactive one (validating and forwarding, ready for failover). The active status is determined by checking if the sequencer's forwarder is nil - active sequencers don't have a forwarder, while inactive ones forward to the active sequencer.
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
MishkaRogachev
approved these changes
Dec 12, 2025
| var isActiveFunc func() bool | ||
| if n.Sequencer != nil { | ||
| isActiveFunc = func() bool { | ||
| _, forwarder := n.Sequencer.GetPauseAndForwarder() |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to double-check, should the pause be handled here in the same way as in Sequencer.getForwarder?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running multiple sequencers in HA mode, all nodes run an ExpressLaneTracker that polls for auction resolution events. This means the "AuctionResolved" and "New express lane auction round" log messages appear on every sequencer node, making it difficult for operators to distinguish which node is active vs standby.
Add isActiveSequencer field to these log messages so operators can identify whether the logging node is the active sequencer (sequencing transactions) or an inactive one (validating and forwarding, ready for failover).
The active status is determined by checking if the sequencer's forwarder is nil - active sequencers don't have a forwarder, while inactive ones forward to the active sequencer.