-
Notifications
You must be signed in to change notification settings - Fork 688
Add new option to allow BlocksReExecutor to commit state to disk #4132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bragaigor
wants to merge
3
commits into
master
Choose a base branch
from
braga/reexecute-commit-blocks-state
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new boolean option to BlocksReExecutor called CommitStateToDisk that will allow BlocksReExecutor.Blocks range to not only re-executes blocks but it also commit their state to triedb. Signed-off-by: Igor Braga <[email protected]>
Signed-off-by: Igor Braga <[email protected]>
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Signed-off-by: Igor Braga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NIT-3154
Add new boolean option to
BlocksReExecutorcalledCommitStateToDiskthat will allowBlocksReExecutor.Blocksrange to not only re-executes blocks but it will also commit their state totriedbon disk.Problem this PR solves:
When using sparse archive node to debug, each api call requiring state usually requires re-execution of tens of thousands of blocks (e.g. sparse archive keeping each 100,000th state, requires re-executing on average 50,000 blocks / ~1 hour of computation). Now, by setting
--blocks-reexecutor.commit-state-to-diskto true,BlocksReExecutorwill not only re-execute the block ranges passed to it, but it will also commit their state totriedbon disk; then users querying RPC calls that require state doesn't need to wait several minutes for state to be re-computed.