Skip to content

Merge geth v1.17.0#4416

Draft
ganeshvanahalli wants to merge 7 commits intomasterfrom
merge-v1.17.0
Draft

Merge geth v1.17.0#4416
ganeshvanahalli wants to merge 7 commits intomasterfrom
merge-v1.17.0

Conversation

@ganeshvanahalli
Copy link
Copy Markdown
Contributor

@ganeshvanahalli ganeshvanahalli commented Feb 20, 2026 •
edited by joshuacolvin0
Loading

pulls in OffchainLabs/go-ethereum#627 that is up-to-date with upstream go-ethereum version 1.17.0

Resolves NIT-4484

@ganeshvanahalli ganeshvanahalli mentioned this pull request Feb 20, 2026
Draft
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 20, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.94%. Comparing base (9d92834) to head (8a2c1f1).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4416   +/-   ##
=======================================
  Coverage   55.94%   55.94%           
=======================================
  Files         506      506           
  Lines       73739    73732    -7     
=======================================
- Hits        41252    41250    -2     
- Misses      27271    27274    +3     
+ Partials     5216     5208    -8

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 20, 2026 •
edited
Loading

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
4961 4 4957 0
View the top 3 failed tests by shortest run time 
TestChallengeToFailedTooFar
Stack Traces | 0.120s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
    challenge_test.go:38: goroutine 3052 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.9/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x2e3ad30, 0xc0031c2700}, {0x2e14900, 0xc000568690}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x9f
        github.com/offchainlabs/nitro/staker/legacy.Require(0xc0031c2700, {0x2e14900, 0xc000568690}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/staker/legacy/common_test.go:14 +0x5d
        github.com/offchainlabs/nitro/staker/legacy.DeployOneStepProofEntry(0xc0031c2700, 0xc00126b4d0, {0x2e2db50, 0xc005d68c00})
        	/home/runner/work/nitro/nitro/staker/legacy/challenge_test.go:38 +0x18d
        github.com/offchainlabs/nitro/staker/legacy.runChallengeTest(0xc0031c2700, 0xc0014b38c0, {0x2e30898, 0xc0014b3920}, 0x1, 0x0, 0xb)
        	/home/runner/work/nitro/nitro/staker/legacy/challenge_test.go:135 +0x425
        github.com/offchainlabs/nitro/staker/legacy.TestChallengeToFailedTooFar(0xc0031c2700)
        	/home/runner/work/nitro/nitro/staker/legacy/challenge_test.go:303 +0x118
        testing.tRunner(0xc0031c2700, 0x2c32850)
        	/opt/hostedtoolcache/go/1.25.9/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.9/x64/src/testing/testing.go:1997 +0x465
        
    challenge_test.go:38: �[31;1m [] replacement transaction underpriced �[0;0m
--- FAIL: TestChallengeToFailedTooFar (0.12s)

TestBatchPosterWithDelayProofsAndBacklog
Stack Traces | 55.500s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
DEBUG[04-23|07:00:49.406] Executing EVM call finished              runtime=1.24949ms
DEBUG[04-23|07:00:49.406] Served eth_call                          reqid=15430 duration=1.309923ms
DEBUG[04-23|07:00:49.406] Served eth_getBlockByNumber              reqid=8389  duration="225.943µs"
DEBUG[04-23|07:00:49.406] Served debug_traceCall                   reqid=8068  duration=4.324101ms
DEBUG[04-23|07:00:49.406] Error destroying a stream group          error="context canceled"
DEBUG[04-23|07:00:49.406] Served eth_getTransactionCount           reqid=8391  duration="85.199µs"
TRACE[04-23|07:00:49.406] Handled RPC response                     reqid=8389  duration="3.086µs"
TRACE[04-23|07:00:49.406] Handled RPC response                     reqid=8391  duration="2.214µs"
DEBUG[04-23|07:00:49.407] Served eth_getBlockByNumber              reqid=8392  duration="96.04µs"
TRACE[04-23|07:00:49.406] Handled RPC response                     reqid=8070  duration="2.133µs"
TRACE[04-23|07:00:49.407] Handled RPC response                     reqid=8069  duration="1.232µs"
TRACE[04-23|07:00:49.407] Handled RPC response                     reqid=8392  duration="1.963µs"
DEBUG[04-23|07:00:49.407] Served eth_getBlockByNumber              reqid=4237  duration="149.3µs"
TRACE[04-23|07:00:49.407] Handled RPC response                     reqid=8073  duration="2.415µs"
DEBUG[04-23|07:00:49.407] Served eth_getBlockByNumber              reqid=3498  duration="146.606µs"
TRACE[04-23|07:00:49.407] Handled RPC response                     reqid=4237  duration="1.723µs"
TRACE[04-23|07:00:49.407] Handled RPC response                     reqid=3498  duration="1.643µs"
TRACE[04-23|07:00:49.407] Handled RPC response                     reqid=8066  duration="2.274µs"
TRACE[04-23|07:00:49.407] Handled RPC response                     reqid=8068  duration="2.976µs"
DEBUG[04-23|07:00:49.407] Served eth_getBlockByNumber              reqid=7739  duration="105.117µs"

TestParentChainEthConfigForkTransition
Stack Traces | 79.460s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [04-23|07:07:17.637] Chain head was updated                   number=58  hash=a11d3f..b63417 root=cce1c5..378909 elapsed="106.519µs"
INFO [04-23|07:07:17.644] Imported new potential chain segment     number=28  hash=d28329..1af5ee blocks=1  txs=1  mgas=0.139  elapsed=9.532ms      mgasps=14.542   triediffs=139.32KiB  triedirty=0.00B
INFO [04-23|07:07:17.647] Chain head was updated                   number=28  hash=d28329..1af5ee root=647e65..2ab054 elapsed="150.071µs"
INFO [04-23|07:07:17.644] Updated parent chain config from eth_config currentTarget=6 currentMax=9 hasNext=false
INFO [04-23|07:07:17.644] Submitted transaction                    hash=0x468782d6a4d72c130ae9bcf6914a7de2abca65af660e5a1b1c91c57536db48c9 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=29   recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1,000,000,000,000
INFO [04-23|07:07:17.645] Submitted transaction                    hash=0x6d2299c666b6c81772248610a6bda98a9dfda667cbec7e6865c12f496e7bf1bf from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=91   recipient=0x0C709F340F0BB2e361229e345B7e26999d0969Ab value=1,000,000,000,000
INFO [04-23|07:07:17.646] Updated payload                          id=0x03aa115180168432 number=306 hash=f72c6c..ff750e txs=1  withdrawals=0 gas=21000      fees=0.0021         root=c84578..eb433a elapsed=617.987ms
INFO [04-23|07:07:17.653] Stopping work on payload                 id=0x03aa115180168432 reason=delivery
INFO [04-23|07:07:17.661] Starting work on payload                 id=0x03ed41f75d67f985
INFO [04-23|07:07:17.662] Imported new potential chain segment     number=306 hash=f72c6c..ff750e blocks=1  txs=1  mgas=0.021  elapsed=10.540ms     mgasps=1.992    triediffs=618.02KiB  triedirty=123.62KiB
INFO [04-23|07:07:17.662] Updated payload                          id=0x03ed41f75d67f985 number=68  hash=430436..a62ed7 txs=1  withdrawals=0 gas=21000      fees=0.002099571306 root=e77184..598945 elapsed=1.077ms
INFO [04-23|07:07:17.662] Chain head was updated                   number=306 hash=f72c6c..ff750e root=c84578..eb433a elapsed="109.535µs"
INFO [04-23|07:07:17.663] Stopping work on payload                 id=0x03ed41f75d67f985 reason=delivery
INFO [04-23|07:07:17.663] Imported new potential chain segment     number=68  hash=430436..a62ed7 blocks=1  txs=1  mgas=0.021  elapsed=1.314ms      mgasps=15.975   triediffs=313.02KiB  triedirty=0.00B
INFO [04-23|07:07:17.664] Chain head was updated                   number=68  hash=430436..a62ed7 root=e77184..598945 elapsed="84.248µs"
INFO [04-23|07:07:17.672] Updated parent chain config from eth_config currentTarget=6 currentMax=9 hasNext=false
INFO [04-23|07:07:17.674] Persisted dirty state to disk            size=535.98KiB elapsed=685.610ms
INFO [04-23|07:07:17.674] Blockchain stopped
    common_test.go:3027: Error ensuring tx succeeded: waitForTx (tx=0xe91ac74587033378f69a69502002f298c2b111d0a86779e324a295358b9fb5f3) got: context canceled
--- FAIL: TestParentChainEthConfigForkTransition (79.46s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@vjoshi-maker vjoshi-maker added the after-next-version This PR shouldn't be merged until after the next version is released label Mar 10, 2026
magicxyyz
magicxyyz reviewed Mar 10, 2026
View reviewed changes
Comment thread execution/gethexec/blockchain.go
MaxAmountOfGasToSkipStateSaving: cachingConfig.MaxAmountOfGasToSkipStateSaving,
StateScheme: cachingConfig.StateScheme,
StateHistory: cachingConfig.StateHistory,
TrienodeHistory: cachingConfig.TrienodeHistory,
Copy link
Copy Markdown
Contributor

@magicxyyz magicxyyz Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more config added in 1.17: FullValueCheckpoint that defaults in geth to 8, while leaving this field uninitialized (so zero) disables this storage optimization.

We need to add FullValueCheckpoint config and set it's default to 8.

https://github.com/OffchainLabs/go-ethereum/blob/654d47c9b338b971159c34a77b85c8ff0203f2a8/triedb/pathdb/config.go#L75

Copy link
Copy Markdown
Member

@joshuacolvin0 joshuacolvin0 Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4492

magicxyyz
magicxyyz requested changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@magicxyyz magicxyyz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add one more new config

joshuacolvin0 and others added 4 commits March 10, 2026 12:58
@joshuacolvin0 @claude
Add FullValueCheckpoint config for pathdb trienode history
0b829dd 
Expose geth's NodeFullValueCheckpoint setting through CachingConfig,
defaulting to 8 to match geth's default. Without this, the field
was left at zero which disables the storage optimization.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@joshuacolvin0
Merge pull request #4492 from OffchainLabs/jco/add-full-value-checkpo…
6bd1ef3 
…int-config

Add FullValueCheckpoint config for pathdb trienode history
@ganeshvanahalli
update geth pin
3b8bed2
@ganeshvanahalli
Merge branch 'master' into merge-v1.17.0
8cb8926
@ganeshvanahalli ganeshvanahalli marked this pull request as draft March 10, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MishkaRogachev MishkaRogachev Awaiting requested review from MishkaRogachev

@Tristan-Wilson Tristan-Wilson Awaiting requested review from Tristan-Wilson

@magicxyyz magicxyyz Awaiting requested review from magicxyyz

@joshuacolvin0 joshuacolvin0 Awaiting requested review from joshuacolvin0

Requested changes must be addressed to merge this pull request.

Assignees

@ganeshvanahalli ganeshvanahalli

Labels

after-next-version This PR shouldn't be merged until after the next version is released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ganeshvanahalli @magicxyyz @joshuacolvin0 @Tristan-Wilson @vjoshi-maker