Fix bug in extracting L2 msgs from batch and enable skipped system_tests

[ganeshvanahalli]

This PR enables those system_tests which were skipped previously because of pending bugs resolution in MEL and it also solves an issue where L2 message extraction from batch segment didn't match the flow currently seen in inboxMultiplexer used by inbox-tracker code.

Now only the system_tests relating to validation will be skipped when MEL is enabled

Resolves NIT-3883

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 34.13%. Comparing base (21e0cea) to head (59fe349).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4551      +/-   ##
==========================================
- Coverage   34.30%   34.13%   -0.17%     
==========================================
  Files         498      498              
  Lines       59096    59099       +3     
==========================================
- Hits        20270    20176      -94     
- Misses      35238    35345     +107     
+ Partials     3588     3578      -10     

[github-actions]

❌ 21 Tests Failed:

Tests completed	Failed	Passed	Skipped
4684	21	4663	0

View the top 3 failed tests by shortest run time

TestEndToEnd_TwoEvilValidators

Stack Traces | -0.000s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]

goroutine 76937 [select, 88 minutes]:
github.com/syndtr/goleveldb/leveldb.(*DB).tCompaction(0xc0051c2540)
	/home/runner/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db_compaction.go:836 +0x6b7
created by github.com/syndtr/goleveldb/leveldb.openDB in goroutine 76868
	/home/runner/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db.go:155 +0x4ee

goroutine 76935 [select, 88 minutes]:
github.com/syndtr/goleveldb/leveldb.(*DB).compactionError(0xc0051c2540)
	/home/runner/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db_compaction.go:91 +0x149
created by github.com/syndtr/goleveldb/leveldb.openDB in goroutine 76868
	/home/runner/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db.go:148 +0x447

goroutine 111746 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Subscription[...]).Next(0x200b980, {0x200b980?, 0xc005c95ef0?})
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:130 +0xd0
github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Spawn(0xc003118460, {0x200b980, 0xc005c95ef0})
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:204 +0x235
created by github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Act in goroutine 103898
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:357 +0x1125

TestEndToEnd_TwoEvilValidators/honest_essential_edges_confirmed_by_challenge_win

Stack Traces | -0.000s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]

goroutine 76937 [select, 88 minutes]:
github.com/syndtr/goleveldb/leveldb.(*DB).tCompaction(0xc0051c2540)
	/home/runner/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db_compaction.go:836 +0x6b7
created by github.com/syndtr/goleveldb/leveldb.openDB in goroutine 76868
	/home/runner/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db.go:155 +0x4ee

goroutine 76935 [select, 88 minutes]:
github.com/syndtr/goleveldb/leveldb.(*DB).compactionError(0xc0051c2540)
	/home/runner/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db_compaction.go:91 +0x149
created by github.com/syndtr/goleveldb/leveldb.openDB in goroutine 76868
	/home/runner/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db.go:148 +0x447

goroutine 111746 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Subscription[...]).Next(0x200b980, {0x200b980?, 0xc005c95ef0?})
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:130 +0xd0
github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Spawn(0xc003118460, {0x200b980, 0xc005c95ef0})
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:204 +0x235
created by github.com/offchainlabs/nitro/bold/challenge/tracker.(*Tracker).Act in goroutine 103898
	/home/runner/work/nitro/nitro/bold/challenge/tracker/tracker.go:357 +0x1125

TestPruningDBSizeReduction

Stack Traces | 0.000s run time

=== RUN   TestPruningDBSizeReduction
--- FAIL: TestPruningDBSizeReduction (0.00s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

[gligneul]

@ganeshvanahalli looks good! Please take a look at the CI job. It seems there is a linter error.

[eljobe]

I have retried the defaults-B test a couple of times on this branch. Are you sure its failure is not related to this change?
@ganeshvanahalli

[ganeshvanahalli]

I have retried the defaults-B test a couple of times on this branch. Are you sure its failure is not related to this change? @ganeshvanahalli

@eljobe CI doesn't fail anymore and the tests pass locally for me too

[joshuacolvin0]

This PR is flaky. Using copilot or Claude will help you narrow down reasons for failures and help you fix issues with this test