Skip to content

Enable JIT validation for MEL#4565

Open
ganeshvanahalli wants to merge 1 commit intomel-validator-createvalidationentryfrom
enable-jit-melvalidation
Open

Enable JIT validation for MEL#4565
ganeshvanahalli wants to merge 1 commit intomel-validator-createvalidationentryfrom
enable-jit-melvalidation

Conversation

@ganeshvanahalli
Copy link
Copy Markdown
Contributor

This PR enables JIT validation for MEL and does necessary plumbing to account for new mel related fields in the global state.

Co-authored by claude

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.62%. Comparing base (a9b2740) to head (fe7279c).
⚠️ Report is 185 commits behind head on mel-validator-createvalidationentry.

Additional details and impacted files
@@                           Coverage Diff                           @@
##           mel-validator-createvalidationentry    #4565      +/-   ##
=======================================================================
- Coverage                                33.89%   33.62%   -0.27%     
=======================================================================
  Files                                      500      500              
  Lines                                    59767    59777      +10     
=======================================================================
- Hits                                     20260    20103     -157     
- Misses                                   35906    36109     +203     
+ Partials                                  3601     3565      -36     

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

❌ 11 Tests Failed:

Tests completed Failed Passed Skipped
4613 11 4602 0
View the top 3 failed tests by shortest run time
TestPruningDBSizeReduction
Stack Traces | 0.000s run time
=== RUN   TestPruningDBSizeReduction
--- FAIL: TestPruningDBSizeReduction (0.00s)
TestAliasingFlaky
Stack Traces | -0.000s run time
=== RUN   TestAliasingFlaky
=== PAUSE TestAliasingFlaky
=== CONT  TestAliasingFlaky
WARN [03-26|20:36:22.960] Getting file info                        dir= error="stat : no such file or directory"
INFO [03-26|20:36:22.960] Started log indexer
INFO [03-26|20:36:22.960] Started log indexer
    common_test.go:775: BuildL1 deployConfig: DeployBold=true, DeployReferenceDAContracts=false
TestBatchPosterL1SurplusMatchesBatchGasFlaky
Stack Traces | 0.580s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
panic: runtime error: invalid memory address or nil pointer dereference [recovered, repanicked]
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2083cb2]

goroutine 16 [running]:
testing.tRunner.func1.2({0x37e6ca0, 0x61fb9c0})
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1875 +0x35b
panic({0x37e6ca0?, 0x61fb9c0?})
	/opt/hostedtoolcache/go/1.25.8/x64/src/runtime/panic.go:783 +0x132
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).GetBatchCount(0x16cb1900?)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:210 +0x12
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).FindInboxBatchContainingMessage(0x0, 0x8)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:225 +0x2f
github.com/offchainlabs/nitro/system_tests.TestBatchPosterL1SurplusMatchesBatchGasFlaky(0xc00010bc00)
	/home/runner/work/nitro/nitro/system_tests/batch_poster_test.go:838 +0x725
testing.tRunner(0xc00010bc00, 0x41b9950)
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1997 +0x465

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link
Copy Markdown
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! quite straightforward

@rauljordan
Copy link
Copy Markdown
Contributor

looks like there is a real failing issue though @ganeshvanahalli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants