Fix flaky pathdb test failures caused by MEL integration#4576
Open
joshuacolvin0 wants to merge 3 commits intomasterfrom
Open
Fix flaky pathdb test failures caused by MEL integration#4576joshuacolvin0 wants to merge 3 commits intomasterfrom
joshuacolvin0 wants to merge 3 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4576 +/- ##
==========================================
- Coverage 34.52% 34.52% -0.01%
==========================================
Files 498 498
Lines 59092 59100 +8
==========================================
+ Hits 20400 20402 +2
- Misses 35067 35071 +4
- Partials 3625 3627 +2 |
Contributor
❌ 10 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Fixes flaky test failures caused by the Message Extraction Layer (MEL) integration by introducing a BatchDataReader interface that abstracts over MEL vs InboxTracker, and adding proper delayed message rollback on accumulator mismatch in addMessages. Key changes: - Add BatchDataReader interface and BatchDataSource() to eliminate duplicated MEL-vs-InboxTracker dispatch across system tests - Roll back delayed messages when AddSequencerBatches detects a mismatch, preventing orphaned DB entries - Wrap both rollback and original mismatch errors in the error chain - Replace unbounded polling loops in tests with deadline-guarded waits - Fix pre-existing diagnostic bug in meaningless_reorg_test.go Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joshuacolvin0
force-pushed
the
fix-pathdb-flaky-tests
branch
from
4bb77fa to
c52a971
Compare
Member
|
Assigned back to @joshuacolvin0 to clean up the lint issues and investigate the still-failing test. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # system_tests/common_test.go
Contributor
|
Awesome, thanks for this PR @joshuacolvin0, I would like to hold this PR off a little bit, if its not urgent, I'm working currently to replace txStreamer taking in both inboxtracker and messageExtractor to just taking in an unified interface similar to your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix nil InboxTracker panic in TestBatchPosterL1SurplusMatchesBatchGasFlaky
by checking MessageExtractor first, matching the pattern used elsewhere.
Fix TestMessageExtractionLayer_TxStreamerHandleReorg timeout by replacing
log message detection with direct balance verification. InitTestLog sets
a global logger, so parallel tests clobber each other's log handlers,
causing the test to miss expected log messages and time out.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com