Log submitted express lane transactions like eth_sendRawTransaction#4588
Open
joshuacolvin0 wants to merge 1 commit intomasterfrom
Open
Log submitted express lane transactions like eth_sendRawTransaction#4588joshuacolvin0 wants to merge 1 commit intomasterfrom
joshuacolvin0 wants to merge 1 commit intomasterfrom
Conversation
The timeboost_sendExpressLaneTransaction RPC endpoint had no logging on success, unlike eth_sendRawTransaction which logs via SubmitTransaction. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4588 +/- ##
==========================================
+ Coverage 34.30% 34.31% +0.01%
==========================================
Files 498 498
Lines 59096 59100 +4
==========================================
+ Hits 20270 20283 +13
+ Misses 35238 35232 -6
+ Partials 3588 3585 -3 |
Contributor
❌ 13 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Contributor
MishkaRogachev
left a comment
MishkaRogachev
left a comment
There was a problem hiding this comment.
Looks good, just a changelog is missing
| if err := a.txPublisher.PublishExpressLaneTransaction(ctx, goMsg); err != nil { | ||
| return err | ||
| } | ||
| sender, _ := types.Sender(types.LatestSignerForChainID(goMsg.ChainId), goMsg.Transaction) |
Contributor
There was a problem hiding this comment.
it maybe worth checking an err from types.Sender
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timeboost_sendExpressLaneTransaction RPC endpoint had no logging
on success, unlike eth_sendRawTransaction which logs via SubmitTransaction.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com