Add exhaustive initialization lint to DelayedInboxMessage#4589
Open
cats2101 wants to merge 1 commit intoOffchainLabs:masterfrom
Open
Add exhaustive initialization lint to DelayedInboxMessage#4589cats2101 wants to merge 1 commit intoOffchainLabs:masterfrom
cats2101 wants to merge 1 commit intoOffchainLabs:masterfrom
Conversation
Annotate DelayedInboxMessage with lint:require-exhaustive-initialization and update all initialization sites to explicitly set all four fields (BlockHash, BeforeInboxAcc, Message, ParentChainBlockNumber). Closes OffchainLabs#3121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DelayedInboxMessagewith// lint:require-exhaustive-initializationBlockHash,BeforeInboxAcc,Message,ParentChainBlockNumber)Changes
Annotation added:
arbnode/mel/messages.go—DelayedInboxMessagestructProduction code fix:
arbnode/inbox_tracker.go— added missingBlockHashfieldTest fixes (added missing zero-value fields):
arbnode/delayed_seq_reorg_test.go— 9 init sites, addedParentChainBlockNumberarbnode/mel/extraction/delayed_message_lookup_test.go— 2 init sitesarbnode/mel/extraction/message_extraction_function_test.go— 2 init sitesarbnode/mel/extraction/messages_in_batch_test.go— 3 init sites (+ addedcommonimport)arbnode/mel/runner/backlog_test.go— 1 init sitearbnode/mel/runner/database_test.go— 2 init sitesarbnode/mel/runner/mel_test.go— 1 init sitemel-replay/merkle_tree_fetcher_test.go— 1 init sitemel-replay/delayed_message_db_test.go— 1 init siteTest plan
go test ./linters/structinit/passesmake lint(requires full build environment with solgen)make teston affected packagesCloses #3121