Skip to content

Use message extractor to completely replace inbox reader and tracker code#4593

Open
ganeshvanahalli wants to merge 5 commits intomel-change-delayedmsg-accumulationfrom
replace-readerandtracker-with-messageextractor
Open

Use message extractor to completely replace inbox reader and tracker code#4593
ganeshvanahalli wants to merge 5 commits intomel-change-delayedmsg-accumulationfrom
replace-readerandtracker-with-messageextractor

Conversation

@ganeshvanahalli
Copy link
Copy Markdown
Contributor

@ganeshvanahalli ganeshvanahalli commented Apr 1, 2026

This PR aims to get rid of pending inbox reader and tracker dependency of nitro nodes, and instead to start using message extractor.

Resolves NIT-4753

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 60.15625% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.53%. Comparing base (81cfdf4) to head (c41d420).

Additional details and impacted files
@@                          Coverage Diff                           @@
##           mel-change-delayedmsg-accumulation    #4593      +/-   ##
======================================================================
+ Coverage                               33.59%   34.53%   +0.93%     
======================================================================
  Files                                     494      494              
  Lines                                   58926    58932       +6     
======================================================================
+ Hits                                    19797    20350     +553     
+ Misses                                  35565    34989     -576     
- Partials                                 3564     3593      +29     

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

❌ 11 Tests Failed:

Tests completed Failed Passed Skipped
4709 11 4698 0
View the top 3 failed tests by shortest run time
TestPruningDBSizeReduction
Stack Traces | 0.000s run time
=== RUN   TestPruningDBSizeReduction
--- FAIL: TestPruningDBSizeReduction (0.00s)
TestRedisProduceComplex/one_producer,_all_consumers_are_active
Stack Traces | 1.230s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[36mDEBUG�[0m[04-01|20:22:02.816] consumer: setting result                 �[36mcid�[0m=e3bfa287-6dab-4dc0-ac1b-b3453d1d5c92 �[36mmsgIdInStream�[0m=1775074921684-0  �[36mresultKeyInRedis�[0m=result-key:stream:f52a6293-8286-4453-af96-87e44ca7d797.1775074921684-0
�[36mDEBUG�[0m[04-01|20:22:02.815] consumer: xdel                           �[36mcid�[0m=50ad845b-ef09-47e9-8c42-7636a1b06a4d �[36mmessageId�[0m=1775074921671-4
�[33mWARN �[0m[04-01|20:22:02.815] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1775074921671-3
�[36mDEBUG�[0m[04-01|20:22:02.816] consumer: xack                           �[36mcid�[0m=ec662a68-09d0-4446-87e2-802177dd0922 �[36mmessageId�[0m=1775074921671-7
�[36mDEBUG�[0m[04-01|20:22:02.816] Redis stream consuming                   �[36mconsumer_id�[0m=81cdb1c7-c7d3-42ca-875c-f333967cea23 �[36mmessage_id�[0m=1775074921684-1
�[36mDEBUG�[0m[04-01|20:22:02.816] consumer: setting result                 �[36mcid�[0m=81cdb1c7-c7d3-42ca-875c-f333967cea23 �[36mmsgIdInStream�[0m=1775074921684-1  �[36mresultKeyInRedis�[0m=result-key:stream:f52a6293-8286-4453-af96-87e44ca7d797.1775074921684-1
�[36mDEBUG�[0m[04-01|20:22:02.816] consumer: xdel                           �[36mcid�[0m=ec662a68-09d0-4446-87e2-802177dd0922 �[36mmessageId�[0m=1775074921671-7
�[36mDEBUG�[0m[04-01|20:22:02.816] Redis stream consuming                   �[36mconsumer_id�[0m=1b7ef49e-3296-4001-9b19-67504b16da6a �[36mmessage_id�[0m=1775074921685-0
�[36mDEBUG�[0m[04-01|20:22:02.816] consumer: xack                           �[36mcid�[0m=81cdb1c7-c7d3-42ca-875c-f333967cea23 �[36mmessageId�[0m=1775074921684-1
�[36mDEBUG�[0m[04-01|20:22:02.816] consumer: setting result                 �[36mcid�[0m=1b7ef49e-3296-4001-9b19-67504b16da6a �[36mmsgIdInStream�[0m=1775074921685-0  �[36mresultKeyInRedis�[0m=result-key:stream:f52a6293-8286-4453-af96-87e44ca7d797.1775074921685-0
�[36mDEBUG�[0m[04-01|20:22:02.817] consumer: xdel                           �[36mcid�[0m=81cdb1c7-c7d3-42ca-875c-f333967cea23 �[36mmessageId�[0m=1775074921684-1
�[36mDEBUG�[0m[04-01|20:22:02.817] consumer: xack                           �[36mcid�[0m=1b7ef49e-3296-4001-9b19-67504b16da6a �[36mmessageId�[0m=1775074921685-0
�[36mDEBUG�[0m[04-01|20:22:02.817] consumer: xack                           �[36mcid�[0m=e3bfa287-6dab-4dc0-ac1b-b3453d1d5c92 �[36mmessageId�[0m=1775074921684-0
�[36mDEBUG�[0m[04-01|20:22:02.817] consumer: xdel                           �[36mcid�[0m=14707e1c-eafc-4657-9391-5bcaec73c9d8 �[36mmessageId�[0m=1775074921671-6
�[36mDEBUG�[0m[04-01|20:22:02.817] consumer: xdel                           �[36mcid�[0m=1b7ef49e-3296-4001-9b19-67504b16da6a �[36mmessageId�[0m=1775074921685-0
�[36mDEBUG�[0m[04-01|20:22:02.817] consumer: xdel                           �[36mcid�[0m=e3bfa287-6dab-4dc0-ac1b-b3453d1d5c92 �[36mmessageId�[0m=1775074921684-0
�[36mDEBUG�[0m[04-01|20:22:02.864] checkResponses                           �[36mresponded�[0m=94 �[36merrored�[0m=0 �[36mchecked�[0m=100
�[36mDEBUG�[0m[04-01|20:22:02.870] redis producer: check responses starting
�[36mDEBUG�[0m[04-01|20:22:02.874] checkResponses                           �[36mresponded�[0m=6  �[36merrored�[0m=0 �[36mchecked�[0m=6
--- FAIL: TestRedisProduceComplex/one_producer,_all_consumers_are_active (1.23s)
TestParentChainEthConfigForkTransition
Stack Traces | 9.220s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [04-01|20:30:54.987] Starting work on payload                 id=0x0318617543657f28
WARN [04-01|20:30:54.988] Failed to fetch parent chain block number for delayed message. Will fall back to BatchMetadata idx=0
INFO [04-01|20:30:54.987] Updated parent chain config from eth_config currentTarget=6  currentMax=9  hasNext=false
INFO [04-01|20:30:54.990] Submitted transaction                    hash=0xcc13ed13bb0f47c571240c3db80ad0df60c3a7f8f9064780ed36a6efb83d89ff from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=414  recipient=0x7E23C8862920797d81916d62c274dd9217113e28 value=1,000,000,000,000
INFO [04-01|20:30:54.990] Updated payload                          id=0x0318617543657f28 number=79  hash=6d762a..3d4c62 txs=1   withdrawals=0 gas=21000      fees=0.002099902004 root=401653..a41658 elapsed=3.043ms
WARN [04-01|20:30:54.992] Failed to fetch parent chain block number for delayed message. Will fall back to BatchMetadata idx=0
INFO [04-01|20:30:54.992] Submitted contract creation              hash=0xa160b8cd44b9ff2e788ab0b09697176362401049d50b88cd37d7293c2d0856ce from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=22   contract=0xa433f59F800E7c1478a6D92d49e18791D5e73A1b value=0
INFO [04-01|20:30:54.993] Stopping work on payload                 id=0x0318617543657f28 reason=delivery
INFO [04-01|20:30:54.993] Starting work on payload                 id=0x03fbec6d99d9fe1a
INFO [04-01|20:30:54.994] Updated payload                          id=0x03fbec6d99d9fe1a number=28  hash=ddbae6..70ef94 txs=1   withdrawals=0 gas=1,215,789  fees=1.215789e-06   root=8e523d..7eabf5 elapsed="584.958µs"
INFO [04-01|20:30:54.994] Stopping work on payload                 id=0x03fbec6d99d9fe1a reason=delivery
INFO [04-01|20:30:54.994] Starting work on payload                 id=0x03f24124d41146f4
INFO [04-01|20:30:54.994] Submitted contract creation              hash=0x46892e322d8f2fe1eb51cd13ac6f2c36381ab9b1c46ae9fa22da1a0dd9bbbcb4 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=19   contract=0x1174d3891010c0e64f57f3E47f1dEd82DC1DFA34 value=0
INFO [04-01|20:30:54.996] Updated payload                          id=0x03f24124d41146f4 number=527 hash=0e887f..babd55 txs=1   withdrawals=0 gas=21000      fees=0.0021         root=f33be5..b92f50 elapsed=2.190ms
WARN [04-01|20:30:54.997] Getting file info                        dir= error="stat : no such file or directory"
--- FAIL: TestParentChainEthConfigForkTransition (9.22s)
WARN [04-01|20:30:55.317] Failed to fetch parent chain block number for delayed message. Will fall back to BatchMetadata idx=174
WARN [04-01|20:30:55.318] Failed to fetch parent chain block number for delayed message. Will fall back to BatchMetadata idx=174
WARN [04-01|20:30:55.318] Failed to fetch parent chain block number for delayed message. Will fall back to BatchMetadata idx=174
INFO [04-01|20:30:55.319] Starting work on payload                 id=0x0346077d7f5763f6

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants