Skip to content

Move ErrResultNotFound sentinel from gethexec to execution package#4630

Closed
joshuacolvin0 wants to merge 1 commit intomasterfrom
fix/move-err-result-not-found
Closed

Move ErrResultNotFound sentinel from gethexec to execution package#4630
joshuacolvin0 wants to merge 1 commit intomasterfrom
fix/move-err-result-not-found

Conversation

@joshuacolvin0
Copy link
Copy Markdown
Member

Move ResultNotFound from execution/gethexec to execution.ErrResultNotFound
so that arbnode (consensus_execution_syncer) can reference the sentinel
without importing the lower-level gethexec package. This breaks the
unnecessary arbnode → gethexec dependency for this error check.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Move ResultNotFound from execution/gethexec to execution.ErrResultNotFound
so that arbnode (consensus_execution_syncer) can reference the sentinel
without importing the lower-level gethexec package. This breaks the
unnecessary arbnode → gethexec dependency for this error check.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@pmikolajczyk41
Copy link
Copy Markdown
Member

duplicated by #4629

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.81%. Comparing base (f7859c3) to head (df9c763).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4630      +/-   ##
==========================================
- Coverage   33.98%   33.81%   -0.17%     
==========================================
  Files         498      498              
  Lines       59879    59879              
==========================================
- Hits        20347    20246     -101     
- Misses      35979    36095     +116     
+ Partials     3553     3538      -15     

@github-actions
Copy link
Copy Markdown
Contributor

❌ 43 Tests Failed:

Tests completed Failed Passed Skipped
4845 43 4802 0
View the top 3 failed tests by shortest run time
TestAllowPostingFirstBatchWhenSequencerMessageCountMismatchEnabled
Stack Traces | -0.000s run time
=== RUN   TestAllowPostingFirstBatchWhenSequencerMessageCountMismatchEnabled
=== PAUSE TestAllowPostingFirstBatchWhenSequencerMessageCountMismatchEnabled
TestBatchPosterDelayBufferEnabled
Stack Traces | -0.000s run time
=== RUN   TestBatchPosterDelayBufferEnabled
=== PAUSE TestBatchPosterDelayBufferEnabled
TestAccessingPathSchemeState
Stack Traces | -0.000s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [04-10|14:44:28.049] Submitted transaction                    hash=0xaee826e7668851924cc9617fa93c5b94d582aeabc5b5e9d7c994a60d7c38f046 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=157 recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1
INFO [04-10|14:44:28.050] Stopping work on payload                 id=0x03e9e84a4368992c reason=delivery
INFO [04-10|14:44:28.051] Starting work on payload                 id=0x0349189489b21aa9
INFO [04-10|14:44:28.052] Transaction pool stopped
INFO [04-10|14:44:28.052] Persisting dirty state                   head=102 root=da1a7d..199a08 layers=102
INFO [04-10|14:44:28.053] Submitted transaction                    hash=0x9615e7f1aa763c23da887def0ebf29e577f8946d711e6ac25192a51fb80ab1d8 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=24  recipient=0xB211efa485d87C29b9486E7631D3140e16D28E08 value=0
INFO [04-10|14:44:28.053] Imported new potential chain segment     number=17  hash=5a1203..425041 blocks=1  txs=2   mgas=6.488  elapsed=8.534ms      mgasps=760.248  triediffs=59.56KiB   triedirty=0.00B
WARN [04-10|14:44:28.054] error applying transaction               tx="{\"type\":\"0x2\",\"chainId\":\"0x64aba\",\"nonce\":\"0x10e\",\"to\":\"0x0c709f340f0bb2e361229e345b7e26999d0969ab\",\"gas\":\"0x7a1200\",\"gasPrice\":\"0x0\",\"maxPriorityFeePerGas\":\"0xbebc200\",\"maxFeePerGas\":\"0xbebc200\",\"value\":\"0xe8d4a51000\",\"input\":\"0x\",\"accessList\":[],\"v\":\"0x0\",\"r\":\"0xdf4963485a7283d0654d893448fa218303e41e959f161d1347a0a56d6b98c0e4\",\"s\":\"0x4f968ee6eb6659dabed2006229e9299f053ccd70551e95a1d8a231a1ec627bb9\",\"yParity\":\"0x0\",\"hash\":\"0x2712e5c45d81800feae08d549320a6c995bc9c0e3d3f7eb5b306a8455ff58d59\"}" err="BlockNumberMin condition not met"
INFO [04-10|14:44:28.054] Chain head was updated                   number=17  hash=5a1203..425041 root=92d76f..7dd8dc elapsed="581.268µs"
INFO [04-10|14:44:28.054] Updated payload                          id=0x0349189489b21aa9 number=348 hash=d8bea6..97dddd txs=2   withdrawals=0 gas=163,070    fees=0.00281035     root=5ad922..ca9092 elapsed=3.646ms
WARN [04-10|14:44:28.055] Served eth_sendRawTransactionConditional reqid=595   duration=5.895646ms    err="BlockNumberMin condition not met"
WARN [04-10|14:44:28.056] error applying transaction               tx="{\"type\":\"0x2\",\"chainId\":\"0x64aba\",\"nonce\":\"0x10e\",\"to\":\"0x0c709f340f0bb2e361229e345b7e26999d0969ab\",\"gas\":\"0x7a1200\",\"gasPrice\":\"0x0\",\"maxPriorityFeePerGas\":\"0xbebc200\",\"maxFeePerGas\":\"0xbebc200\",\"value\":\"0xe8d4a51000\",\"input\":\"0x\",\"accessList\":[],\"v\":\"0x0\",\"r\":\"0xdf4963485a7283d0654d893448fa218303e41e959f161d1347a0a56d6b98c0e4\",\"s\":\"0x4f968ee6eb6659dabed2006229e9299f053ccd70551e95a1d8a231a1ec627bb9\",\"yParity\":\"0x0\",\"hash\":\"0x2712e5c45d81800feae08d549320a6c995bc9c0e3d3f7eb5b306a8455ff58d59\"}" err="BlockNumberMax condition not met"
WARN [04-10|14:44:28.057] Served eth_sendRawTransactionConditional reqid=596   duration=2.145155ms    err="BlockNumberMax condition not met"
INFO [04-10|14:44:28.059] New local node record                    seq=1,775,832,268,058 id=47beefcd59481682   ip=127.0.0.1 udp=0 tcp=0
INFO [04-10|14:44:28.059] Started P2P networking                   self=enode://f05543fea06ac7dcdcf30be25710501142b511c0d2589b669c49797100e9cde7a8fc129eda0084cd9db81fb230f352da57ba65996f72c4dd0f8e1d0fca2980e7@127.0.0.1:0
WARN [04-10|14:44:28.059] error applying transaction               tx="{\"type\":\"0x2\",\"chainId\":\"0x64aba\",\"nonce\":\"0x10e\",\"to\":\"0x0c709f340f0bb2e361229e345b7e26999d0969ab\",\"gas\":\"0x7a1200\",\"gasPrice\":\"0x0\",\"maxPriorityFeePerGas\":\"0xbebc200\",\"maxFeePerGas\":\"0xbebc200\",\"value\":\"0xe8d4a51000\",\"input\":\"0x\",\"accessList\":[],\"v\":\"0x0\",\"r\":\"0xdf4963485a7283d0654d893448fa218303e41e959f161d1347a0a56d6b98c0e4\",\"s\":\"0x4f968ee6eb6659dabed2006229e9299f053ccd70551e95a1d8a231a1ec627bb9\",\"yParity\":\"0x0\",\"hash\":\"0x2712e5c45d81800feae08d549320a6c995bc9c0e3d3f7eb5b306a8455ff58d59\"}" err="BlockNumberMin condition not met"
WARN [04-10|14:44:28.060] Served eth_sendRawTransactionConditional reqid=597   duration=2.024358ms    err="BlockNumberMin condition not met"
INFO [04-10|14:44:28.061] Persisted dirty state to disk            size=448.27KiB  elapsed=8.631ms
INFO [04-10|14:44:28.061] Blockchain stopped
INFO [04-10|14:44:28.054] Starting work on payload                 id=0x037b0d5110fb658c

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@pmikolajczyk41 pmikolajczyk41 deleted the fix/move-err-result-not-found branch April 10, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants