Move ErrResultNotFound sentinel from gethexec to execution package#4630
Closed
joshuacolvin0 wants to merge 1 commit intomasterfrom
Closed
Move ErrResultNotFound sentinel from gethexec to execution package#4630joshuacolvin0 wants to merge 1 commit intomasterfrom
joshuacolvin0 wants to merge 1 commit intomasterfrom
Conversation
Move ResultNotFound from execution/gethexec to execution.ErrResultNotFound so that arbnode (consensus_execution_syncer) can reference the sentinel without importing the lower-level gethexec package. This breaks the unnecessary arbnode → gethexec dependency for this error check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
duplicated by #4629 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4630 +/- ##
==========================================
- Coverage 33.98% 33.81% -0.17%
==========================================
Files 498 498
Lines 59879 59879
==========================================
- Hits 20347 20246 -101
- Misses 35979 36095 +116
+ Partials 3553 3538 -15 |
Contributor
❌ 43 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ResultNotFound from execution/gethexec to execution.ErrResultNotFound
so that arbnode (consensus_execution_syncer) can reference the sentinel
without importing the lower-level gethexec package. This breaks the
unnecessary arbnode → gethexec dependency for this error check.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com