Sync SP1 README with new Makefile workflow; add run target#4672
Open
bragaigor wants to merge 2 commits intozk-prove-any/sp1-runnerfrom
Open
Sync SP1 README with new Makefile workflow; add run target#4672bragaigor wants to merge 2 commits intozk-prove-any/sp1-runnerfrom
bragaigor wants to merge 2 commits intozk-prove-any/sp1-runnerfrom
Conversation
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## zk-prove-any/sp1-runner #4672 +/- ##
============================================================
- Coverage 52.67% 33.82% -18.85%
============================================================
Files 506 501 -5
Lines 60415 60225 -190
============================================================
- Hits 31821 20371 -11450
- Misses 23493 36296 +12803
+ Partials 5101 3558 -1543 |
When you invoke $(MAKE) in a recipe, make automatically: 1. Sets MAKEFLAGS (the make variable). 2. Exports MAKEFLAGS as an environment variable. 3. The sub-make reads MAKEFLAGS from the environment at startup and applies those flags. Passing $(MAKEFLAGS) as positional arguments (make $(MAKEFLAGS)) is redundant, not additive — it's the same info via a second channel. And it's actively harmful because of the argv quoting rules: MAKEFLAGS stores short flags concatenated without a leading dash (e.g. w, sw, j4), so when interpolated onto a command line, w becomes a target, sw becomes a target, etc. The env-based path has no such ambiguity because make parses it itself. Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Contributor
❌ 11 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4667, which moved SP1's build pipeline from build.sh to a per-target Makefile but left
crates/sp1/README.mddescribing the old flow. This PR:crates/sp1/README.md: replaces the deletedbuild.shinstructions with the Makefile-driven workflow: install-sp1, brotli, nitro-deps, build, record-blocks, run, clean. Documents the newtarget/sp1/block-inputs/layout (transfer.json, solidity.json, stylus.json, stylus_heavy.json, mixed.json) produced by record-blocks, updates every example invocationto use the new paths, and points users at
system_tests/block_recording_test.gofor adding new blocks.crates/sp1/Makefile: two small quality-of-life fixes plus a new target:"Building brotli for RISC-V (SP1)…"progress line, and backs upbrotli/CMakeLists.txtbefore patching it so that a trap ... EXIT INT TERM restores the original on any exit path (success, failure,Ctrl-C). Previously the submodule was left dirty after every run.target/sp1/block-inputs/$(BLOCK).json. The recipe is intentionally unsilenced so make echoes the fully-expanded command for debugging..github/workflows/zk-proving.yml: replaces the inline sp1-runner invocation with make -C crates/sp1 run BLOCK=stylus, so CI and the README now go through the same code path.part of NIT-4820