Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR updates our atomic operations to use
Go 1.19's
newer typed atomic approach instead of the old function-based method. We're changing fields likeuint64
toatomic.Uint64
so we can write cleaner code likecounter.Add(1)
instead ofatomic.AddUint64(&counter, 1)
. This removes the need for pointer handling and gives us better compile-time safety when multiple threads access the same variables in validator operations.Which issues(s) does this PR fix?
The function-based atomics allowed accidental non-atomic access to shared variables, causing race conditions in concurrent validator operations. The verbose
atomic.AddUint64(&counter, 1)
syntax was harder to maintain. Typed atomics enforce atomic-only access at compile time and use cleaner method calls, preventing threading bugs in validator sync committee statistics where multiple goroutines update counters simultaneously.Acknowledgements