[WIP] Fix subscription race conditions #15769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
reviewed
Sep 29, 2025
| // Even if sub is nil (topic already exists), we need to track the subnet | ||
| // to avoid repeated subscription attempts every slot. | ||
| if sub == nil { | ||
| // Topic already exists, get the existing subscription for tracking |
There was a problem hiding this comment.
why does sub==nil mean that the topic already exists?
There was a problem hiding this comment.
My understanding is that sub == nil being true means: the topic either exists or someone else has reserved it or we failed to subscribe to the topic earlier. In all of these cases, it is worth tracking the corresponding sub.
The comment "topic already exists" is a simplification, I can edit it.
This was referenced Sep 30, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Attempts to fix #15738
Other notes for review
Alternative proposals:
Acknowledgements