Skip to content

monitoring/prometheus: close HTTP response body in test #15831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

monitoring/prometheus: close HTTP response body in test #15831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27c1100
Update service_test.go
prestoalvarez Oct 9, 2025
86e8139
Create prestoalvarez_patch3.md
prestoalvarez Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/prestoalvarez_patch3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix resource leak in prometheus service test by properly closing HTTP response body.
2 changes: 2 additions & 0 deletions monitoring/prometheus/service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ func TestLifecycle(t *testing.T) {
// Query the service to ensure it really started.
resp, err := http.Get(fmt.Sprintf("http://localhost:%d/metrics", port))
require.NoError(t, err)
// Close response body to avoid leaking connections.
defer resp.Body.Close()
assert.NotEqual(t, uint64(0), resp.ContentLength, "Unexpected content length 0")

err = prometheusService.Stop()
Expand Down