beacon-chain/kv: remove pruned blocks from parent index during historical deletion #15838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
When pruning with DeleteHistoricalDataBeforeSlot, we deleted blocks but did not remove each child root from its parent’s entry in blockParentRootIndicesBucket (schema: parentRoot -> packed children). The code only deleted the key equal to the child’s own root (i.e., “this block as parent”), leaving stale child references under the actual parent’s key.
This is a problem because ParentRoot-based queries can return pruned (non-existent) child roots, causing downstream lookups to fail and wasting resources. It also breaks index consistency guarantees.
This change fetches the block within the same transaction, derives its ParentRoot, calls deleteMatchingParentIndex to remove the child from the parent’s packed list, and only then deletes the block and related data. This mirrors the single-block DeleteBlock behavior and keeps the parent index consistent during historical pruning.
Acknowledgements