Skip to content

fix: TestSubmitAggregateAndProof_AggregateOk to assert RPC result and not mutate pool #15861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: TestSubmitAggregateAndProof_AggregateOk to assert RPC result and not mutate pool #15861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe5dca6
fix: TestSubmitAggregateAndProof_AggregateOk to assert RPC result and…
GarmashAlex Oct 14, 2025
7fd2917
Create GarmashAlex_fix-validator-aggregator.md
GarmashAlex Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions beacon-chain/rpc/prysm/v1alpha1/validator/aggregator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"github.com/OffchainLabs/prysm/v6/config/params"
"github.com/OffchainLabs/prysm/v6/crypto/bls"
"github.com/OffchainLabs/prysm/v6/encoding/bytesutil"
"github.com/OffchainLabs/prysm/v6/encoding/ssz/equality"
ethpb "github.com/OffchainLabs/prysm/v6/proto/prysm/v1alpha1"
"github.com/OffchainLabs/prysm/v6/proto/prysm/v1alpha1/attestation"
attaggregation "github.com/OffchainLabs/prysm/v6/proto/prysm/v1alpha1/attestation/aggregation/attestations"
Expand Down Expand Up @@ -169,15 +170,15 @@ func TestSubmitAggregateAndProof_AggregateOk(t *testing.T) {

require.NoError(t, aggregatorServer.AttPool.SaveAggregatedAttestation(att0))
require.NoError(t, aggregatorServer.AttPool.SaveAggregatedAttestation(att1))
_, err = aggregatorServer.SubmitAggregateSelectionProof(ctx, req)
res, err := aggregatorServer.SubmitAggregateSelectionProof(ctx, req)
require.NoError(t, err)

aggregatedAtts := aggregatorServer.AttPool.AggregatedAttestations()
wanted, err := attaggregation.AggregatePair(att0, att1)
require.NoError(t, err)
if reflect.DeepEqual(aggregatedAtts, wanted) {
// Validate the server returned one of the pre-existing aggregated attestations (no pool mutation expected).
if !equality.DeepEqual(res.AggregateAndProof.Aggregate, att0) && !equality.DeepEqual(res.AggregateAndProof.Aggregate, att1) {
t.Error("Did not receive wanted attestation")
}
// Optionally confirm the pool was not mutated by the call.
assert.Equal(t, 2, len(aggregatorServer.AttPool.AggregatedAttestations()))
}

func TestSubmitAggregateAndProof_AggregateNotOk(t *testing.T) {
Expand Down
3 changes: 3 additions & 0 deletions changelog/GarmashAlex_fix-validator-aggregator.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Fixed

- fix TestSubmitAggregateAndProof_AggregateOk to assert RPC result and not mutate pool (#15861).