removing TODO, and have wait for activation depend on health tracker - #17369
Open
james-prysm wants to merge 2 commits into
Open
removing TODO, and have wait for activation depend on health tracker#17369james-prysm wants to merge 2 commits into
james-prysm wants to merge 2 commits into
Conversation
james-prysm
marked this pull request as ready for review
August 18, 2026 03:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
a follow up to #17285 (comment)
simplifies some checks by having wait for activation depend on the health monitor instead of retrying the api endpoint each time. checks ever 12 seconds and is intentionally "dumb" so the wall clock on health check may be at most 12 seconds off on the interval, but I'd argue it's worth the simplification.
refactored some small things. Tested in kurtosis
Which issue(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements