Update examples to work in SDK workspace #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes NIT-3852
rory-ocl
requested review from
diegoximenes,
gligneul,
joshuacolvin0 and
rauljordan
In CI, clippy was previously not run on examples since they were not a part of the workspace project.
We need to go back and make generics (erc20, erc721) work as well.
# Conflicts: # examples/hello_world/Cargo.toml # examples/inheritance/src/lib.rs
* Pass constructor value during deployment. * Remove conditional traits. * Install stylus-beta.
alexandrosfilios
force-pushed
the
examples-workspace
branch
from
eca2f7c to
8603c1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Examples are now part of the SDK workspace. I removed
.cargo/config.tomlin each since they can read from the root workspace. Open to input about keeping it if the examples are intended to be more standalone. I chose not to change the Cargo.toml dependencies toworkspace = truefor that reason.rust-toolchain.tomlcurrently still required for these.Fixes NIT-3852
Checklist