-
Notifications
You must be signed in to change notification settings - Fork 109
export-abi support for the new inheritance model #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f83a793
to
47e43f2
Compare
interface ICallee is ITrait1, ITrait2 { | ||
function noInputNoOutput() external view; | ||
} | ||
interface ITrait1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe very edge case, but in theory we could implement the same generic interface twice (for different generics), e.g.
impl Trait1<String> for Callee {}
impl Trait1<U256> for Callee {}
Then we could either re-define the attribute as
#[implements(Trait1<U256> as Trait1Number, Trait1<String> as Trait1String)]
That would require also some renaming of the methods though. Maybe it would be simpler to return an error if it is the case, or at least document it in the README to avoid the scenario.
Description
Resolves NIT-3911
This PR includes the following changes:
What is missing:
Checklist