Skip to content

Add symlink to README.md for crates.io #213

Add symlink to README.md for crates.io

Add symlink to README.md for crates.io #213

GitHub Actions / clippy succeeded Nov 27, 2024 in 0s

clippy

22 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 22
Note 0
Help 0

Versions

  • rustc 1.84.0-beta.1 (b4297a573 2024-11-26)
  • cargo 1.84.0-beta.1 (66221abde 2024-11-19)
  • clippy 0.1.84 (b4297a573b 2024-11-26)

Annotations

Check warning on line 455 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:455:21
    |
455 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/tx.rs:47:1
    |
47  | / wrap_hostio!(
48  | |     /// Gets the top-level sender of the transaction. The semantics are equivalent to that of the
49  | |     /// EVM's [`ORIGIN`] opcode.
50  | |     ///
51  | |     /// [`ORIGIN`]: https://www.evm.codes/#32
52  | |     origin ORIGIN tx_origin Address
53  | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 455 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:455:21
    |
455 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/tx.rs:42:1
    |
42  | / wrap_hostio!(
43  | |     /// Gets the gas price in wei per gas, which on Arbitrum chains equals the basefee.
44  | |     gas_price GAS_PRICE tx_gas_price U256
45  | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:448:21
    |
448 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/tx.rs:18:1
    |
18  | / wrap_hostio! {
19  | |     /// Gets the price of ink in evm gas basis points. See [`Ink and Gas`] for more information on
20  | |     /// Stylus's compute-pricing model.
21  | |     ///
22  | |     /// [`Ink and Gas`]: https://docs.arbitrum.io/stylus/concepts/stylus-gas
23  | |     ink_price INK_PRICE tx_ink_price u32
24  | | }
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 455 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:455:21
    |
455 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/msg.rs:37:1
    |
37  | / wrap_hostio!(
38  | |     /// Get the ETH value in wei sent to the program.
39  | |     value VALUE msg_value U256
40  | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 455 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:455:21
    |
455 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/msg.rs:23:1
    |
23  | / wrap_hostio!(
24  | |     /// Gets the address of the account that called the program. For normal L2-to-L2 transactions
25  | |     /// the semantics are equivalent to that of the EVM's [`CALLER`] opcode, including in cases
26  | |     /// arising from [`DELEGATE_CALL`].
...   |
34  | |     sender SENDER msg_sender Address
35  | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:448:21
    |
448 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/msg.rs:18:1
    |
18  | / wrap_hostio!(
19  | |     /// Whether the current call is reentrant.
20  | |     reentrant REENTRANT msg_reentrant bool
21  | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 106 in stylus-sdk/src/deploy/raw.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/deploy/raw.rs:106:9
    |
106 |         RETURN_DATA_LEN.set(revert_data_len);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ mutable reference to mutable static
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives

Check warning on line 455 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:455:21
    |
455 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/contract.rs:63:1
    |
63  | / wrap_hostio!(
64  | |     /// Gets the address of the current program.
65  | |     address ADDRESS contract_address Address
66  | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:448:21
    |
448 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/contract.rs:57:1
    |
57  | / wrap_hostio!(
58  | |     /// Returns the length of the last EVM call or deployment return result, or `0` if neither have
59  | |     /// happened during the program's execution.
60  | |     return_data_len RETURN_DATA_LEN return_data_size usize
61  | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 228 in stylus-sdk/src/call/raw.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/call/raw.rs:228:17
    |
228 |                 RETURN_DATA_LEN.set(outs_len);
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ mutable reference to mutable static
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives

Check warning on line 448 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:448:21
    |
448 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/block.rs:48:1
    |
48  | / wrap_hostio!(
49  | |     /// Gets a bounded estimate of the Unix timestamp at which the Sequencer sequenced the
50  | |     /// transaction. See [`Block Numbers and Time`] for more information on how this value is
51  | |     /// determined.
...   |
54  | |     timestamp TIMESTAMP block_timestamp u64
55  | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:448:21
    |
448 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/block.rs:39:1
    |
39  | / wrap_hostio!(
40  | |     /// Gets a bounded estimate of the L1 block number at which the Sequencer sequenced the
41  | |     /// transaction. See [`Block Numbers and Time`] for more information on how this value is
42  | |     /// determined.
...   |
45  | |     number NUMBER block_number u64
46  | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:448:21
    |
448 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/block.rs:34:1
    |
34  | / wrap_hostio!(
35  | |     /// Gets the gas limit of the current block.
36  | |     gas_limit GAS_LIMIT block_gas_limit u64
37  | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 455 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:455:21
    |
455 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/block.rs:28:1
    |
28  | / wrap_hostio!(
29  | |     /// Gets the coinbase of the current block, which on Arbitrum chains is the L1 batch poster's
30  | |     /// address.
31  | |     coinbase COINBASE block_coinbase Address
32  | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 448 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:448:21
    |
448 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/block.rs:23:1
    |
23  | / wrap_hostio!(
24  | |     /// Gets the unique chain identifier of the Arbitrum chain.
25  | |     chainid CHAINID chainid u64
26  | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 455 in stylus-sdk/src/hostio.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> stylus-sdk/src/hostio.rs:455:21
    |
455 |               unsafe{ $cache.get() }
    |                       ^^^^^^ mutable reference to mutable static
    |
   ::: stylus-sdk/src/block.rs:18:1
    |
18  | / wrap_hostio!(
19  | |     /// Gets the basefee of the current block.
20  | |     basefee BASEFEE block_basefee U256
21  | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: `#[warn(static_mut_refs)]` on by default
    = note: this warning originates in the macro `wrap_hostio` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 119 in stylus-sdk/src/storage/array.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manually reimplementing `div_ceil`

warning: manually reimplementing `div_ceil`
   --> stylus-sdk/src/storage/array.rs:119:22
    |
119 |         let packed = (N + density - 1) / density; // ceil division for packed items.
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `N.div_ceil(density)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
    = note: `#[warn(clippy::manual_div_ceil)]` on by default

Check warning on line 119 in stylus-sdk/src/call/context.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> stylus-sdk/src/call/context.rs:119:6
    |
119 | impl<'a, T> StaticCallContext for &'a mut T where T: TopLevelStorage {}
    |      ^^                            ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
119 - impl<'a, T> StaticCallContext for &'a mut T where T: TopLevelStorage {}
119 + impl<T> StaticCallContext for &mut T where T: TopLevelStorage {}
    |

Check warning on line 116 in stylus-sdk/src/call/context.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> stylus-sdk/src/call/context.rs:116:6
    |
116 | impl<'a, T> StaticCallContext for &'a T where T: TopLevelStorage {}
    |      ^^                            ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
116 - impl<'a, T> StaticCallContext for &'a T where T: TopLevelStorage {}
116 + impl<T> StaticCallContext for &T where T: TopLevelStorage {}
    |

Check warning on line 96 in stylus-sdk/src/call/context.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
  --> stylus-sdk/src/call/context.rs:96:6
   |
96 | impl<'a, T> CallContext for &'a T
   |      ^^                      ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
   |
96 - impl<'a, T> CallContext for &'a T
96 + impl<T> CallContext for &T
   |

Check warning on line 297 in stylus-proc/src/macros/sol_interface.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'ast

warning: the following explicit lifetimes could be elided: 'ast
   --> stylus-proc/src/macros/sol_interface.rs:297:6
    |
297 | impl<'ast> Visit<'ast> for FunctionParameters {
    |      ^^^^        ^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
297 - impl<'ast> Visit<'ast> for FunctionParameters {
297 + impl Visit<'_> for FunctionParameters {
    |

Check warning on line 297 in stylus-proc/src/macros/sol_interface.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'ast

warning: the following explicit lifetimes could be elided: 'ast
   --> stylus-proc/src/macros/sol_interface.rs:297:6
    |
297 | impl<'ast> Visit<'ast> for FunctionParameters {
    |      ^^^^        ^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
297 - impl<'ast> Visit<'ast> for FunctionParameters {
297 + impl Visit<'_> for FunctionParameters {
    |