Deterministic deployment of contracts using Create2 #114
Conversation
| // Upgrade Executor | ||
| // (Deployed using ABI and bytecode from @offchainlabs/upgrade-executor) | ||
| // | ||
| const upgradeExecutorTemplate = await deployContract( |
There was a problem hiding this comment.
Note that in the original script we used the UpgradeExecutor abi and bytecode from the UpgradeExecutor repo instead of the factory from the sdk (source)
There was a problem hiding this comment.
i think we should keep that behavior, i left a comment about it
| Signer, | ||
| Wallet, | ||
| } from 'ethers' | ||
| import { Interface, hexZeroPad, defaultAbiCoder } from 'ethers/lib/utils' |
There was a problem hiding this comment.
| import { Interface, hexZeroPad, defaultAbiCoder } from 'ethers/lib/utils' | |
| import { Interface, hexZeroPad } from 'ethers/lib/utils' |
There was a problem hiding this comment.
There are some unused imports here, as well as some commented bits, that are used in #115 .
And I just realized that while separating the PRs, this one was left a bit messy, apologies for that 🙏
There was a problem hiding this comment.
Happy to clean this up, and move whatever is needed to the other PR if needed.
| // Parent chain helper contracts | ||
| // | ||
| // Multicall2 | ||
| const parentMulticall2 = await deployContract( |
There was a problem hiding this comment.
probably a nit but i think it'd be easier to review the diff if we left the variable / function names the same and left the deployments in the same order
There was a problem hiding this comment.
Yeah, I see what you mean. We decided to start changing the terminology used from L1/L2 to Parent/Child, and I tried to keep the changes only to the function that I was working on, but seeing now the diff, I think this PR could have been split into 2: add create2, and changes in terminology.
Co-authored-by: Henry <[email protected]>
Co-authored-by: Henry <[email protected]>
2 participants
This PR adds the possibility of deploying the TokenBridgeCreator contract along with its templates to deterministic addresses using Create2.
Verification of contracts is done in #115 , so that PR should be merged before this one.