Make master vault upgradable #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

waelsy123 wants to merge 10 commits into wa/master-vault-isolated from ybb/upgradable-master-vault

+161 −58

Open

Make master vault upgradable #127

fixup! feat: make master vault beacon upgradable

GitHub Advanced Security / Slither succeeded Oct 19, 2025 in 2s

2 new alerts including 2 medium severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

2 medium

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 123 in contracts/tokenbridge/libraries/vault/MasterVault.sol

Code scanning / Slither

Dangerous strict equalities Medium

MasterVault._setSubVault(IERC4626,uint256) uses a dangerous strict equality:
- totalSupply() == 0

Check warning on line 123 in contracts/tokenbridge/libraries/vault/MasterVault.sol

Code scanning / Slither

Reentrancy vulnerabilities Medium

Reentrancy in MasterVault._setSubVault(IERC4626,uint256):
External calls:
- IERC20(asset()).safeApprove(address(_subVault),type()(uint256).max)
- subShares = _subVault.deposit(totalAssets(),address(this))
State variables written after the call(s):
- subVault = _subVault
MasterVault.subVault can be used in cross function reentrancies:
- MasterVault._convertToAssets(uint256,MathUpgradeable.Rounding)
- MasterVault._convertToShares(uint256,MathUpgradeable.Rounding)
- MasterVault._deposit(address,address,uint256,uint256)
- MasterVault._revokeSubVault(uint256)
- MasterVault._setSubVault(IERC4626,uint256)
- MasterVault._withdraw(address,address,address,uint256,uint256)
- MasterVault.maxDeposit(address)
- MasterVault.maxMint(address)
- MasterVault.setSubVault(IERC4626,uint256)
- MasterVault.subVault
- MasterVault.totalAssets()
- MasterVault.withdrawPerformanceFees()