MasterVault rebalance slippage #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

godzillaba wants to merge 4 commits into wa/master-vault-isolated from ha/rebalance-slippage

Open

MasterVault rebalance slippage #172

expand subvault requirements

GitHub Advanced Security / Slither succeeded Jan 29, 2026 in 2s

1 new alert including 1 medium severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

1 medium

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 351 in contracts/tokenbridge/libraries/vault/MasterVault.sol

Code scanning / Slither

Reentrancy vulnerabilities Medium

Reentrancy in MasterVault.rebalance(int256):
External calls:
- subVaultShares = subVault.withdraw(withdrawAmount,address(this),address(this))
- asset.safeApprove(address(subVault),depositAmount)
- subVaultShares_scope_0 = subVault.deposit(depositAmount,address(this))
State variables written after the call(s):
- lastRebalanceTime = uint40(block.timestamp)
MasterVault.lastRebalanceTime can be used in cross function reentrancies:
- MasterVault.lastRebalanceTime