Conversation
OmarBasem
reviewed
Apr 24, 2026
| ) | ||
| } | ||
|
|
||
| function Erc20ApprovalItem({ |
Member
There was a problem hiding this comment.
Are these items meant to be components in different files?
Collaborator
Author
There was a problem hiding this comment.
I'm not sure yet. Depends on how they are going to be presented in the designs. I think they may be just separate expandable cards - for now it makes sense keeping them here.
brtkx
force-pushed
the
bartek/signing/decode-wallet-send-calls
branch
from
ff130f8 to
91c9852
Compare
brtkx
force-pushed
the
bartek/signing/decode-typed-data
branch
from
268a94e to
4084032
Compare
OmarBasem
previously approved these changes
Apr 24, 2026
brtkx
force-pushed
the
bartek/signing/decode-wallet-send-calls
branch
from
91c9852 to
b78c739
Compare
OmarBasem
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes fs-1966