Skip to content

feat(react): expose stamper, storage and shouldInit params#73

Open
andrascodes wants to merge 2 commits intoandras/refactor-core-use-atob-and-btoa-instead-of-bufferfrom
andras/feat-react-expose-stamper-storage-and-shouldinit-params
Open

feat(react): expose stamper, storage and shouldInit params#73
andrascodes wants to merge 2 commits intoandras/refactor-core-use-atob-and-btoa-instead-of-bufferfrom
andras/feat-react-expose-stamper-storage-and-shouldinit-params

Conversation

@andrascodes
Copy link
Copy Markdown

@andrascodes andrascodes commented Apr 1, 2026

Depends on #72. This PR is part of a stack created with Aviator.

Closes FS-1927

Passing through the new wallet-core options (storage, stampers...etc.) to wallet-react as well.
Additionally, removing or guarding the usages of window in wallet-react - added a shouldInit param to replace the check for "only init client-side" (still defaulting to typeof window !== "undefined" for now)

@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from ebacb9a to da2f27c Compare April 1, 2026 17:11
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from e94d813 to de941af Compare April 1, 2026 17:11
@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from da2f27c to f3577ac Compare April 1, 2026 21:08
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from de941af to 6e07c19 Compare April 1, 2026 21:08
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from 6e07c19 to ca5f62a Compare April 7, 2026 11:21
@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from f3577ac to 4a78517 Compare April 7, 2026 11:21
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from ca5f62a to 4bcc9a3 Compare April 7, 2026 16:17
@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from 4a78517 to 068598d Compare April 7, 2026 16:17
@andrascodes andrascodes marked this pull request as ready for review April 7, 2026 16:54
@OmarBasem
Copy link
Copy Markdown
Member

Passing through the new wallet-core options (storage, stampers...etc.) to wallet-react as well.
Additionally, removing or guarding the usages of window in wallet-react - added a shouldInit param to replace the check for "only init client-side" (still defaulting to typeof window !== "undefined" for now)

Can you please add more details on not just what is being changed, but also why, for more clarity and context

@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from 068598d to c1d3e47 Compare April 20, 2026 10:11
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from 4bcc9a3 to 5b62471 Compare April 20, 2026 10:11
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from 5b62471 to 529ba6c Compare April 24, 2026 17:57
@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from c1d3e47 to 746cf47 Compare April 24, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants