Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the combined add-in & Teams tab sample #1527

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Rick-Kirkham
Copy link
Contributor

@Rick-Kirkham Rick-Kirkham commented Jan 13, 2025

This PR updates the add-in part of the sample for a combined Teams tab and Office add-in.

  1. The add-in now uses new Office.js APIs to automatically reflect changes in the user's chosen Office theme.
  2. The latest versions of the office-addin-* utility libraries are used.
  3. In the manifest, the deprecated "file" property is replaced with the "url" property.
  4. The deprecated teams-fx CLI is replaced with the teamsapp-CLI (only in the add-in part of the sample)
  5. The sample ReadMe is updated to account for items 1 - 4.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • samples/tab-add-in-combined/nodejs/add-in/package.json: Language not supported
  • samples/tab-add-in-combined/nodejs/appManifest/manifest.json: Language not supported
  • samples/tab-add-in-combined/nodejs/demo-manifest/manifest.json: Language not supported
Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clear commented doubt?

Copy link
Contributor

@Harikrishnan-MSFT Harikrishnan-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good Approved !!!

Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct, Approving!

@Pawank-MSFT Pawank-MSFT merged commit e90c738 into OfficeDev:main Feb 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants