[Outlook] (spam reporting) Add support for the unified manifest for Microsoft 365 #940
+563
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rick-Kirkham
requested changes
Feb 28, 2025
|
|
||
| 1. Follow the steps in [Try it out](#try-it-out) to test the sample. | ||
|
|
||
| > **Note**: You can't debug a spam-reporting add-in that uses the unified manifest at this time. |
There was a problem hiding this comment.
Just for my personal curiosity, why would this be? The JavaScript that's being debugged is the same, isn't it? Why would the type of manifest matter?
| 1. Download the **outlook-spam-reporting.zip** file from this sample to a folder on your computer. | ||
| 1. Sideload the sample to Outlook by following the instructions in [Sideload with the Teams Toolkit CLI (command-line interface)](https://learn.microsoft.com/office/dev/add-ins/testing/sideload-add-in-with-unified-manifest#sideload-with-the-teams-toolkit-cli-command-line-interface). | ||
| 1. Follow the steps in [Try it out](#try-it-out) to test the sample. | ||
|
|
There was a problem hiding this comment.
Should we tell readers how to stop and uninstall with teamsapp uninstall? In the localhost section, we tell them how to stop.
| 1. Download the **manifest.xml** file from this sample to a folder on your computer. | ||
| 1. Sideload the add-in only manifest in Outlook on the web or on Windows (new or classic) by following the manual instructions in [Sideload Outlook add-ins for testing](https://learn.microsoft.com/office/dev/add-ins/outlook/sideload-outlook-add-ins-for-testing#sideload-manually). | ||
| 1. Follow the steps in [Try it out](#try-it-out) to test the sample. | ||
|
|
There was a problem hiding this comment.
Should we tell readers how to stop and uninstall?
| { | ||
| "id": "onSpamReport", | ||
| "type": "executeFunction", | ||
| "displayName": "onSpamReport", |
There was a problem hiding this comment.
"actions.displayName" is only used in add-ins that have keyboard shortcuts. If this add-in doesn't let's remove this property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Adds support for the unified manifest for Microsoft 365 to the spam-reporting sample.