-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visionOS client type #2670
base: main
Are you sure you want to change the base?
Add visionOS client type #2670
Conversation
This pull request contains changes to the runtime.ts file. If you, as the author of this PR, have made changes to the Runtime interface please review RUNTIME.md to determine if a new runtime version is required. Please reply to this comment stating what changes, if any, were made to the runtime object and whether a new runtime version was required. |
@wyAbhishek , as talked offline, while we are working on official support(i.e, passing platform type from host to app through hub sdk), another way that developers can do is to check visionOS identifier in the user agent, if they want to get unblocked faster before we complete the chain of support. I am signing off on this PR for now. Tagging @TrevorJoelHarris FYI, |
This is not very straightforward as checking user agent. In our test, user agent of iPad and visionOS is similar. |
Description
Teams iOS client runs on VisionOS. Teams iOS client supports web apps built on Teams JS SDK on VisionOS. This PR adds visionOS as a new HostClientType in the Teams JS SDK. This change will enable app developers to find out if app is running on visionOS and write conditional code (if required).
Main changes in the PR:
Unit Tests added:
Updated existing tests which included iPadOS. Added visionOS also in list of client type in such tests. Ideally all these tests should pass for visionOS also.
End-to-end tests added:
No
Additional Requirements
Change file added:
Yes