-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update authentication.notifySuccess function documentation with secure usage guidance #2685
Conversation
@AE-MS - Given the size of the info, our thought is that it might go better with the remarks section. Since Note: The
@erikadoyle as an fyi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and provided feedback in comments.
4917db0
Description
The
authentication.notifySuccess
function did not explicitly discuss secure usage guidance and this PR adds it.Separately, I am working with the docs team to get the prose documentation pages (here and here) updated to be more explicit about this.
The final docs now look like this, after feedback from @JoshuaPartlow:

This is obviously the local generation of the docs -- they will be formatted slightly differently on the official site.