Skip to content

Adding externalAppCardActionsForDA capability #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 25, 2025
Merged

Conversation

lakhveerk
Copy link
Contributor

For more information about how to contribute to this repo, visit this page.

Description

Added externalAppCardActionsForDA capability with actionOpenUrlDialog function that is designed for bizchat to call. Added UTs, E2e tests, and test app related changes for this capability.

Validation

Validation performed:

  1. <Step 1>
  2. <Step 2>

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.
Yes

End-to-end tests added:

Yes,
This PR have the test cases for isSupported functions. The rest of the e2e tests will be added to host sdk

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

Yes

@lakhveerk lakhveerk requested a review from a team as a code owner March 17, 2025 23:04
Copy link
Contributor

This pull request contains changes to the runtime.ts file. If you, as the author of this PR, have made changes to the Runtime interface please review RUNTIME.md to determine if a new runtime version is required. Please reply to this comment stating what changes, if any, were made to the runtime object and whether a new runtime version was required.

Copy link
Contributor

github-actions bot commented Mar 17, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/teams-js/dist/esm/packages/teams-js/src/index.js 182.41 KB (+0.63% 🔺) 3.7 s (+0.63% 🔺) 2 s (+20.58% 🔺) 5.6 s

@lakhveerk
Copy link
Contributor Author

This pull request contains changes to the runtime.ts file. If you, as the author of this PR, have made changes to the Runtime interface please review RUNTIME.md to determine if a new runtime version is required. Please reply to this comment stating what changes, if any, were made to the runtime object and whether a new runtime version was required.

Added a new capability to run time. A new runtime is not needed because it does not edit any of the existing capabilities.

ndangudubiyyam
ndangudubiyyam previously approved these changes Mar 21, 2025
MengyiGong
MengyiGong previously approved these changes Mar 21, 2025
@lakhveerk lakhveerk dismissed stale reviews from MengyiGong and ndangudubiyyam via 1f30026 March 21, 2025 20:36
jekloudaMSFT
jekloudaMSFT previously approved these changes Mar 21, 2025
ndangudubiyyam
ndangudubiyyam previously approved these changes Mar 24, 2025
@lakhveerk lakhveerk enabled auto-merge (squash) March 25, 2025 22:18
@lakhveerk lakhveerk merged commit 574ae92 into main Mar 25, 2025
59 checks passed
@lakhveerk lakhveerk deleted the lakhveer/DADialog branch March 25, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants