Skip to content

replaced auth.auth default url by localhost:4000 #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KangxuanYe
Copy link
Contributor

@KangxuanYe KangxuanYe commented Apr 16, 2025

For more information about how to contribute to this repo, visit this page.

Description

{"url":"https://www.microsoft.com"} is an invalid default input, which will be blocked by TJS. Use localhost:4000 for default input on test instead.


Screenshot 2025-04-16 at 3 09 57 PM

@KangxuanYe KangxuanYe requested a review from a team as a code owner April 16, 2025 22:06
Copy link
Contributor

github-actions bot commented Apr 16, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/teams-js/dist/esm/packages/teams-js/src/index.js 186.57 KB (0%) 3.8 s (0%) 1.6 s (-6.17% 🔽) 5.4 s

@KangxuanYe KangxuanYe enabled auto-merge (squash) April 16, 2025 22:35
@@ -131,7 +131,7 @@ const Authenticate = (): React.ReactElement =>
},
},
},
defaultInput: '{"url":"https://www.microsoft.com"}',
defaultInput: '{"url":"https://localhost:4000"}',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KangxuanYe would this work without the :4000 tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean {"url":"localhost"}?

@KangxuanYe KangxuanYe disabled auto-merge April 26, 2025 00:58
@KangxuanYe KangxuanYe enabled auto-merge (squash) April 26, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants