Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outlook] (spam reporting) Document improvements #4912

Merged
merged 12 commits into from
Feb 27, 2025

Conversation

samantharamon
Copy link
Contributor

Documents the following spam-reporting improvements:

  • Radio buttons in the preprocessing dialog.
  • The "Don't show this message again" option in the preprocessing dialog.
  • Ability to open a task pane after reporting a message.

Related PR:
OfficeDev/office-js-docs-reference#2145
DefinitelyTyped/DefinitelyTyped#71221

Copy link
Contributor

Learn Build status updates of commit e3eef7c:

✅ Validation status: passed

File Status Preview URL Details
docs/images/spam-reporting-progress-notification.png ✅Succeeded View
docs/images/spam-reporting-suppress-dialog.png ✅Succeeded View
docs/outlook/spam-reporting.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit cb10c70:

✅ Validation status: passed

File Status Preview URL Details
docs/images/spam-reporting-progress-notification.png ✅Succeeded View
docs/images/spam-reporting-suppress-dialog.png ✅Succeeded View
docs/outlook/spam-reporting.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@ElizabethSamuel-MSFT ElizabethSamuel-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments but generally looks good

Co-authored-by: Elizabeth Samuel <[email protected]>
Copy link
Contributor

Learn Build status updates of commit 0126137:

✅ Validation status: passed

File Status Preview URL Details
docs/images/spam-reporting-progress-notification.png ✅Succeeded View
docs/images/spam-reporting-suppress-dialog.png ✅Succeeded View
docs/outlook/spam-reporting.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit bd8c217:

💡 Validation status: suggestions

File Status Preview URL Details
docs/outlook/spam-reporting.md 💡Suggestion View Details
docs/images/spam-reporting-progress-notification.png ✅Succeeded View
docs/images/spam-reporting-suppress-dialog.png ✅Succeeded View

docs/outlook/spam-reporting.md

  • Line 470, Column 67: [Suggestion: learn-site-link-broken - See documentation] Link '/javascript/api/requirement-sets/outlook/requirement-set-1.15/outlook-requirement-set-1.15' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 517, Column 91: [Suggestion: learn-site-link-broken - See documentation] Link '/javascript/api/requirement-sets/outlook/requirement-set-1.15/outlook-requirement-set-1.15' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit edb9448:

💡 Validation status: suggestions

File Status Preview URL Details
docs/outlook/spam-reporting.md 💡Suggestion View Details
docs/images/spam-reporting-progress-notification.png ✅Succeeded View
docs/images/spam-reporting-suppress-dialog.png ✅Succeeded View

docs/outlook/spam-reporting.md

  • Line 470, Column 67: [Suggestion: learn-site-link-broken - See documentation] Link '/javascript/api/requirement-sets/outlook/requirement-set-1.15/outlook-requirement-set-1.15' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 517, Column 91: [Suggestion: learn-site-link-broken - See documentation] Link '/javascript/api/requirement-sets/outlook/requirement-set-1.15/outlook-requirement-set-1.15' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 46394c9:

💡 Validation status: suggestions

File Status Preview URL Details
docs/outlook/spam-reporting.md 💡Suggestion View Details
docs/images/spam-reporting-progress-notification.png ✅Succeeded View
docs/images/spam-reporting-suppress-dialog.png ✅Succeeded View

docs/outlook/spam-reporting.md

  • Line 475, Column 67: [Suggestion: learn-site-link-broken - See documentation] Link '/javascript/api/requirement-sets/outlook/requirement-set-1.15/outlook-requirement-set-1.15' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 522, Column 91: [Suggestion: learn-site-link-broken - See documentation] Link '/javascript/api/requirement-sets/outlook/requirement-set-1.15/outlook-requirement-set-1.15' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit d582d63:

✅ Validation status: passed

File Status Preview URL Details
docs/images/spam-reporting-progress-notification.png ✅Succeeded View
docs/images/spam-reporting-suppress-dialog.png ✅Succeeded View
docs/outlook/spam-reporting.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 543f1c0:

✅ Validation status: passed

File Status Preview URL Details
docs/images/spam-reporting-progress-notification.png ✅Succeeded View
docs/images/spam-reporting-suppress-dialog.png ✅Succeeded View
docs/outlook/spam-reporting.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@samantharamon samantharamon marked this pull request as ready for review February 27, 2025 18:57
@samantharamon samantharamon merged commit 1de10bb into main Feb 27, 2025
2 checks passed
@samantharamon samantharamon deleted the samramon-spam-reporting-improvements branch February 27, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants