Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all hosts] (Developer Experience) Adjust lint configuration for eslint v9 #5006

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

AlexJerabek
Copy link
Collaborator

Based on upstream changes to the Office Add-ins tooling for the linter: OfficeDev/Office-Addin-Scripts#917

Copy link
Contributor

Learn Build status updates of commit 571dd7f:

✅ Validation status: passed

File Status Preview URL Details
docs/overview/set-up-your-dev-environment.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

]
}
1. In the root of the project, create a text file named **eslint.config.js** (or **.mjs**), if there isn't one already there. Be sure to inherit the recommended configuration for `eslint-plugin-office-addins`. The `plugins` array should include `eslint-plugin-office-addins`. The following is a simple example that includes settings for TypeScript. Your **eslint.config.js** file may have additional properties and configurations.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically plugins is not an array anymore . . . it is an object.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Corrected.

Copy link
Contributor

Learn Build status updates of commit 8de9973:

✅ Validation status: passed

File Status Preview URL Details
docs/overview/set-up-your-dev-environment.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@AlexJerabek AlexJerabek marked this pull request as ready for review January 29, 2025 17:30
@AlexJerabek
Copy link
Collaborator Author

@millerds, since your upstream changes were checked in, I'll merge this PR by EOD. Please let me know if there are any objections.

@AlexJerabek AlexJerabek merged commit 245808c into main Feb 12, 2025
2 checks passed
@AlexJerabek AlexJerabek deleted the AlexJ-Lint branch February 12, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants