[agents] 本番レスポンスから内部エラー詳細を隠す - #115
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
本番レスポンスからデータベースや外部 API の内部エラー詳細が露出し得る問題を修正します。
HTTP レスポンスの秘匿と Workers Observability を分離し、クライアントには内部情報を返さず、Workers Logs には障害調査に必要なスタックを残します。
やったこと / やってないこと
やったこと
developmentと明示された場合だけ、HTTP レスポンスへ内部エラーのdetailsを含める fail-closed な判定へ変更ENVIRONMENT: "production"、staging にENVIRONMENT: "staging"を設定application_errorとしてname・message・stackを構造化して記録detailsは Workers Logs の記録対象から除外ENVIRONMENTの型定義を削除やってないこと
動作確認
pnpm test(247 passed / 1 skipped)pnpm typecheckpnpm lint(既存警告のみ、エラーなし)pnpm format:checkpnpm buildwrangler deploy --dry-runwrangler deploy --dry-run