Skip to content

Fix blank recurring page, avatar crash, loading skeleton, and empty state - #1016

Merged
OlaGreat merged 1 commit into
OlaGreat:mainfrom
oluebubejoy:feat/issues-957-960
Aug 26, 2026
Merged

Fix blank recurring page, avatar crash, loading skeleton, and empty state#1016
OlaGreat merged 1 commit into
OlaGreat:mainfrom
oluebubejoy:feat/issues-957-960

Conversation

@oluebubejoy

Copy link
Copy Markdown
Contributor

Fixes #957, Fixes #958, Fixes #959, Fixes #960

What changed

Why

How to test

  • Verify recurring page shows "No recurring support yet" when all subscriptions are cancelled
  • Verify profiles with empty displayName render ? fallback instead of crashing
  • Verify notification preferences show skeleton rows while loading
  • Verify support-history tab shows only "no matches" when filters match nothing, not "No transactions yet"

…tate

- OlaGreat#957: Compute hasAny from active+paused subscriptions only, not the
  full array including cancelled entries
- OlaGreat#958: Guard avatar fallback against empty displayName in explore
  page and app-shell search dropdown
- OlaGreat#959: Render skeleton placeholder in NotificationPreferences while
  loading instead of returning null
- OlaGreat#960: Gate EmptyState on transactions.length === 0 so filtered-empty
  and truly-empty states show the correct message

Fixes OlaGreat#957, Fixes OlaGreat#958, Fixes OlaGreat#959, Fixes OlaGreat#960
@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

@oluebubejoy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@OlaGreat
OlaGreat merged commit 107ff09 into OlaGreat:main Aug 26, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment