Fix blank recurring page, avatar crash, loading skeleton, and empty state - #1016
Merged
Merged
Conversation
…tate - OlaGreat#957: Compute hasAny from active+paused subscriptions only, not the full array including cancelled entries - OlaGreat#958: Guard avatar fallback against empty displayName in explore page and app-shell search dropdown - OlaGreat#959: Render skeleton placeholder in NotificationPreferences while loading instead of returning null - OlaGreat#960: Gate EmptyState on transactions.length === 0 so filtered-empty and truly-empty states show the correct message Fixes OlaGreat#957, Fixes OlaGreat#958, Fixes OlaGreat#959, Fixes OlaGreat#960
|
@oluebubejoy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #957, Fixes #958, Fixes #959, Fixes #960
What changed
hasAnyfrom onlyactiveSubscriptions.length + pausedSubscriptions.length, not the fullsubscriptionsarray — prevents blank page when all subscriptions are cancelled|| '?'inexplore/page.tsxandapp-shell.tsx, matching the safe pattern already inprofile-card.tsxNotificationPreferenceswhile loading instead of returningnull, eliminating the blank gap on the Settings pageEmptyStateblock ontransactions.length === 0so filtered-empty searches show only the "no matches" message, not a contradictory "No transactions yet"Why
displayNamecrashes the Explore grid and search dropdownHow to test
?fallback instead of crashing