fix: wallet spinner, trim validation, paste cleanup, search race - #1017
Merged
OlaGreat merged 2 commits intoAug 26, 2026
Merged
Conversation
…reat#953, OlaGreat#954) - Add connectingWalletId state set before adapter.connect() so the per-button spinner appears immediately on the clicked wallet button - Trim display name and username in create-profile step 1 validation so whitespace-only input is rejected Closes OlaGreat#953 Closes OlaGreat#954
…laGreat#955, OlaGreat#956) - Fix inverted paste cleanup: always trim whitespace, then truncate G-prefixed addresses longer than 56 chars (was only truncating non-G strings which could never become valid) - Add AbortController to search fetch so stale responses from earlier keystrokes are cancelled instead of overwriting newer results Closes OlaGreat#955 Closes OlaGreat#956
|
@ritaifeoluwa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #953
Closes #954
Closes #955
Closes #956
What changed
connectingWalletIdstate set synchronously beforeadapter.connect(), so the per-button loading spinner appears immediately on the clicked wallet instead of never rendering.trim()to display name and username validation in create-profile step 1, rejecting whitespace-only inputAbortControllerto search fetch so stale responses from earlier keystrokes are cancelled instead of overwriting newer resultsWhy
How to test
🤖 Generated with Claude Code