fix(ci): Sentry guard, Node version consistency, engines field, READM… - #1018
Merged
Conversation
…E prereqs (OlaGreat#998, OlaGreat#999) OlaGreat#998 - Add if: secrets.SENTRY_AUTH_TOKEN != '' guard to the Sentry sourcemap upload step in backend.yml. Without this, every push to main fails Backend CI at the last step when SENTRY_AUTH_TOKEN is not configured (forks, pre-Sentry setup), producing a red X on main for a missing optional integration. OlaGreat#999 - Pin Node.js to 22.x consistently across all three workflows. e2e.yml was on 20.x while frontend.yml and backend.yml were on 22.x, meaning E2E never validated against the same runtime the app ships on. Also adds engines: { node: '>=22.0.0' } to both backend/package.json and frontend/package.json, and updates README.md prerequisites from 'Node.js 18+' to 'Node.js 22+' so all three sources of truth agree. Remaining issues in this branch (to be fixed by contributor): OlaGreat#997 - contract-deploy.yml deploy job missing outputs block; notify-success always falls back to hardcoded 'testnet' string. OlaGreat#989 - contract/README.md CLI and JS invocation examples use stale flag names and omit the required asset parameter. Closes OlaGreat#998 Closes OlaGreat#999 Closes OlaGreat#997 Closes OlaGreat#989
|
@sarah-fi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…E prereqs (#998, #999)
#998 - Add if: secrets.SENTRY_AUTH_TOKEN != '' guard to the Sentry sourcemap upload step in backend.yml. Without this, every push to main fails Backend CI at the last step when SENTRY_AUTH_TOKEN is not configured (forks, pre-Sentry setup), producing a red X on main for a missing optional integration.
#999 - Pin Node.js to 22.x consistently across all three workflows. e2e.yml was on 20.x while frontend.yml and backend.yml were on 22.x, meaning E2E never validated against the same runtime the app ships on. Also adds engines: { node: '>=22.0.0' } to both backend/package.json and frontend/package.json, and updates README.md prerequisites from 'Node.js 18+' to 'Node.js 22+' so all three sources of truth agree.
: #997 - contract-deploy.yml deploy job missing outputs block; notify-success always falls back to hardcoded 'testnet' string.
#989 - contract/README.md CLI and JS invocation examples use stale flag names and omit the required asset parameter.
Closes #998
Closes #999
Closes #997
Closes #989