fixes applied

[Biokes]

Fix #1047 - Webhook creation error handling## Fix #1048 - Support transactions error handling## Fix #1049 - Update test to expect throw instead of "error" return## Fix #1050 - Add asset validation to milestone POST and PATCH

First, let me check how accepted assets are structured to understand the validation logic:Now let me update the milestone schema to include assetIssuer and add the validation:Now add validation to POST:Now add validation to PATCH:Perfect! Now let me generate the PR description:Perfect! Now let me create a summary of what was done:

Summary

I've successfully fixed all 4 issues in the new branch fix/issues-1047-1048-1049-1050. Here's what was changed:

✅ Issue #1047 - Webhook Creation Error Handling

• File: backend/src/app.ts (line ~2824)
• Fix: Wrapped endpoint in try-catch to handle P2034 serialization failures and unexpected errors gracefully
• Impact: Prevents backend crashes from concurrent webhook creation

✅ Issue #1048 - Support Transactions Error Handling

• File: backend/src/app.ts (line ~3288)
• Fix: Removed throw error; and added proper error logging with 500 response
• Impact: Prevents backend crashes on transient DB errors in highest-traffic endpoint

✅ Issue #1049 - Test Assertion Update

• File: backend/src/verify-transaction.test.ts (line ~406)
• Fix: Changed test from expecting result === "error" to assert.rejects() expecting throw
• Impact: Test now correctly validates new throw-based behavior

✅ Issue #1050 - Milestone Asset Validation

• Files: backend/src/app.ts (POST at ~3950, PATCH at ~4015)
• Fix:
  • Added assetIssuer to schema
  • Added accepted-asset validation to both POST and PATCH
  • Added automatic currentAmount reset when asset changes
• Impact: Prevents creators from setting milestones with unsupported assets

Closes #1047
Closes #1048
Closes #1049
Closes #1050

[drips-wave]

@Biokes Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits