fix(ci): enforce Lighthouse performance budgets - #1081
Merged
OlaGreat merged 1 commit intoAug 30, 2026
Merged
Conversation
lighthouserc.js used the invalid `assert.budgets: "budget.json"` key — LHCI has no such key, so the budgets were silently never checked. Even if it were valid, the Lighthouse job runs with `working-directory: frontend` and invokes `--config=../lighthouserc.js`, so the relative "budget.json" path would have resolved to frontend/budget.json, which never existed. Fold budget.json's resourceSizes/resourceCounts limits directly into the assert.assertions block as resource-summary:*:size/count assertions, the real LHCI mechanism for this, and delete the now-redundant budget.json.
|
@precious-akpan Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lighthouserc.jsusedassert.budgets: "budget.json", which is not a real LHCI config key — LHCI never enforced the budgets.working-directory: frontendand invokes--config=../lighthouserc.js, so a relative"budget.json"path would resolve tofrontend/budget.json, which never existed — only the repo-rootbudget.jsondid.budget.json'sresourceSizes/resourceCountslimits directly intoassert.assertionsasresource-summary:*:size/resource-summary:*:countassertions (the real LHCI mechanism for this), converting KB budgets to the bytesresource-summary:*:sizeaudits expect. Deleted the now-redundantbudget.jsonand its stale path-filter entries in the workflow.Closes #1034
Test plan
node -e "require('./lighthouserc.js')"— config parses and the new assertions serialize with the expected byte-converted thresholds.budget.jsonanywhere in the repo (docs, workflows, code).