Translations update from Hosted Weblate#139
Open
weblate wants to merge 9 commits into
Open
Conversation
Currently translated at 100.0% (876 of 876 strings) Translation: Ferrite/Ferrite UI Translate-URL: https://hosted.weblate.org/projects/ferrite/ferrite-ui/ja/
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdates Japanese and Estonian locale files: Japanese adds/changes editor sync and split-view strings, conflict/recovery messages, pipeline/Zen/onboarding strings; Estonian revises recent headings and encoding hints, expands HTML/PDF export dialogs, large settings/editor text, and various UI/notification labels. ChangesJapanese UI Localization Updates
Estonian UI Localization Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Currently translated at 46.1% (404 of 876 strings) Translation: Ferrite/Ferrite UI Translate-URL: https://hosted.weblate.org/projects/ferrite/ferrite-ui/et/
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@locales/et.yaml`:
- Around line 163-168: The tooltip strings in locales/et.yaml (keys
encoding_tooltip and rainbow_tooltip) are never used because
src/app/status_bar.rs currently builds tooltips with hardcoded format!(...)
calls; update the rendering code that creates the encoding and rainbow tooltips
(e.g., the function or impl that builds the status bar/tooltips in
status_bar.rs) to fetch the localized template by key (encoding_tooltip and
rainbow_tooltip), substitute the %{encoding} and %{status} placeholders with the
current values, and fall back to an English/default template if the localization
entry is missing; specifically replace the format!(...) usages for encoding and
rainbow tooltips with calls to the app’s i18n/localization accessor and apply
runtime substitution so the translations in locales/et.yaml are displayed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Comment on lines
+163
to
+168
| encoding_tooltip: |- | ||
| Faili kodeering: %{encoding} | ||
| %{info}Muutmiseks klõpsa | ||
| rainbow_tooltip: |- | ||
| Vikerkaareveergude värvimine: %{status} | ||
| Klõpsa vahetamiseks |
There was a problem hiding this comment.
Tooltip translations are currently unreachable from the status bar.
Line 163–168 define localized tooltip strings, but src/app/status_bar.rs currently renders encoding and rainbow tooltips with hardcoded English format!(...) text, so these translations won’t be shown.
Suggested runtime wiring (in src/app/status_bar.rs)
- rainbow_button_response.clone().on_hover_text(format!(
- "Rainbow column coloring: {}\nClick to toggle",
- if rainbow_enabled { "On" } else { "Off" }
- ));
+ rainbow_button_response.clone().on_hover_text(
+ t!(
+ "status.rainbow_tooltip",
+ status = if rainbow_enabled { t!("common.on") } else { t!("common.off") },
+ )
+ .to_string(),
+ );
- encoding_button_response.clone().on_hover_text(format!(
- "File encoding: {}\n{}Click to change",
- encoding_display,
- if tab.detected_encoding.is_some() {
- "Detected. "
- } else {
- "Default. "
- }
- ));
+ encoding_button_response.clone().on_hover_text(
+ t!(
+ "status.encoding_tooltip",
+ encoding = encoding_display,
+ info = if tab.detected_encoding.is_some() {
+ t!("status.encoding_detected_prefix")
+ } else {
+ t!("status.encoding_default_prefix")
+ },
+ )
+ .to_string(),
+ );🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@locales/et.yaml` around lines 163 - 168, The tooltip strings in
locales/et.yaml (keys encoding_tooltip and rainbow_tooltip) are never used
because src/app/status_bar.rs currently builds tooltips with hardcoded
format!(...) calls; update the rendering code that creates the encoding and
rainbow tooltips (e.g., the function or impl that builds the status bar/tooltips
in status_bar.rs) to fetch the localized template by key (encoding_tooltip and
rainbow_tooltip), substitute the %{encoding} and %{status} placeholders with the
current values, and fall back to an English/default template if the localization
entry is missing; specifically replace the format!(...) usages for encoding and
rainbow tooltips with calls to the app’s i18n/localization accessor and apply
runtime substitution so the translations in locales/et.yaml are displayed.
Currently translated at 52.8% (463 of 876 strings) Translation: Ferrite/Ferrite UI Translate-URL: https://hosted.weblate.org/projects/ferrite/ferrite-ui/et/
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@locales/et.yaml`:
- Line 679: The translation for the key not_structured contains a typo ("poel");
update the value for not_structured in locales/et.yaml to replace "poel" with
the correct Estonian word "pole" so the string reads "See pole struktureeritud
andmefail". Ensure you only modify the value for the not_structured key and keep
the rest of the file unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| format_failed: 'Vormindamine ei õnnestunud: %{error}' | ||
| parse_error: 'Viga töölemisel/parsimisel: %{error}' | ||
| no_document_validate: Pole dokumenti, mida kontrollida | ||
| not_structured: See poel struktureeritud andmefail |
There was a problem hiding this comment.
Fix typo in translation.
The word "poel" appears to be a typo. In Estonian, "pole" means "is not", which fits the context ("This is not a structured data file").
🔤 Proposed fix
- not_structured: See poel struktureeritud andmefail
+ not_structured: See pole struktureeritud andmefail📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| not_structured: See poel struktureeritud andmefail | |
| not_structured: See pole struktureeritud andmefail |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@locales/et.yaml` at line 679, The translation for the key not_structured
contains a typo ("poel"); update the value for not_structured in locales/et.yaml
to replace "poel" with the correct Estonian word "pole" so the string reads "See
pole struktureeritud andmefail". Ensure you only modify the value for the
not_structured key and keep the rest of the file unchanged.
Currently translated at 61.6% (540 of 876 strings) Translation: Ferrite/Ferrite UI Translate-URL: https://hosted.weblate.org/projects/ferrite/ferrite-ui/et/
Currently translated at 100.0% (877 of 877 strings) Translation: Ferrite/Ferrite UI Translate-URL: https://hosted.weblate.org/projects/ferrite/ferrite-ui/ja/
Currently translated at 86.6% (760 of 877 strings) Translation: Ferrite/Ferrite UI Translate-URL: https://hosted.weblate.org/projects/ferrite/ferrite-ui/es/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translations update from Hosted Weblate for Ferrite/Ferrite UI.
Current translation status:
Summary by CodeRabbit