Skip to content

Add update_member and get_members_xlsx methods #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add update_member and get_members_xlsx methods #197

wants to merge 4 commits into from

Conversation

alistair0adams
Copy link

Added two methods

  1. update_member() which will POST updated member data back to Spond
  2. get_members_xlsx() which will download the Excel sheet that can be manually downloaded from the Spond website. This can easily then be converted into a Dataframe.

@elliot-100
Copy link
Collaborator

elliot-100 commented Mar 26, 2025 •
edited
Loading

Thanks for this @alistair0adams .

Are you OK to add the missing return annotation? Should be JSONDict.

alistair0adams
alistair0adams commented Mar 26, 2025
View reviewed changes
Copy link
Author

@alistair0adams alistair0adams left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSONDict annotation added

@elliot-100
Copy link
Collaborator

Sorry @alistair0adams have been on other projects. Will try to test in next 1-2 weeks.

@elliot-100 elliot-100 self-assigned this Apr 18, 2025
@elliot-100 elliot-100 self-requested a review April 18, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliot-100 elliot-100 Awaiting requested review from elliot-100

Assignees

@elliot-100 elliot-100

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alistair0adams @elliot-100 @alistair-adams-ridecell